Commit Graph

1107 Commits

Author SHA1 Message Date
Andrew Nicols 0a4dd3ab6b MDL-43411 JavaScript: Correct checks for section support to use helper function 2013-12-23 09:45:41 +08:00
Tim Hunt 65c22578bf MDL-43068 course&gradebook: fix use of new API in old branches. 2013-12-04 15:34:31 +00:00
Tim Hunt 9c4dd6381f MDL-43068 course&gradebook: show/hide cm & CONTROLS_GRADE_VISIBILITY
Making a quiz visible on the course page, of via the settings form,
could cause the grade item to become visible in the gradebook, even
though the quiz supports FEATURE_CONTROLS_GRADE_VISIBILITY to ensure
that when the grades are hidden in the quiz settings, they do not appear
in the gradebook.

Now, if a module supports FEATURE_CONTROLS_GRADE_VISIBILITY, then
set_coursemodule_visible calls the _grade_item_update callback to update
the grade item(s).

In addition, there was a bug when saving the quiz form, where it used
the value of $cm->visible from the database, which was wrong if the
value of cm->visible had just been changed on the setting form.
2013-11-28 10:03:49 +00:00
Damyon Wiese fa2d417f36 Merge branch 'wip-MDL-41517-m25' of git://github.com/marinaglancy/moodle into MOODLE_25_STABLE 2013-09-09 12:10:53 +08:00
Sam Hemelryk 971d920469 MDL-41417 course: fixed idnumbertaken string 2013-09-09 12:16:17 +12:00
Mark Nelson 33a42df4ad MDL-41417 course: allow the use of duplicated idnumbers if they existed before fix 2013-09-06 15:19:01 +08:00
Francis Devine 85251082bf MDL-41417 course: prevent duplicate idnumbers being used when updating a course 2013-09-06 15:17:00 +08:00
Marina Glancy ff8018c65c MDL-41517 Do not call fix_course_sortorder unnecessarily
Thanks to Thomas Worthington
2013-09-03 13:45:56 +10:00
Marina Glancy c6af0e03cb MDL-36690 Do not cache objects inside course.modinfo as they may fail to serialize
convert moodle_url (all other fields are numbers or strings) to string before caching and then back to moodle_url when restoring.
Otherwise serialized modinfo can contain \0 byte which cause problems in Postgres DB
2013-08-21 13:09:36 +10:00
Sam Hemelryk 3f1c01de8d Merge branch 'MDL-41045-m25' of git://github.com/sammarshallou/moodle into MOODLE_25_STABLE 2013-08-13 10:19:16 +12:00
Marina Glancy 7e7e871915 MDL-41114 Avoid unnecessary retrieving of coursecat from DB
- course category depth can be estimated in make_categories_options() by the number of separators
2013-08-12 15:11:16 +10:00
sam marshall 99aa447550 MDL-41045 course_add_cm_to_section should not test for sections unless necessary 2013-08-07 17:18:41 +01:00
Andrew Davis a1d43d9e4f MDL-36090 core_grade: added logging of overriding of student grades 2013-06-10 12:35:03 +12:00
Damyon Wiese b55248d5ad MDL-39462 course: Fix typo in $changesinccoursecat 2013-05-09 14:22:26 +08:00
Marina Glancy b80a50f7c9 MDL-39462 added missing clearing of coursecat cache 2013-05-08 11:02:45 +10:00
Marina Glancy 0fd2635038 MDL-38592 Settings for courses lists on front page are made more user friendly
- 'List of courses' is split into 'List of courses' (available) and 'Enrolled courses', CFG->disablemycourses is deprecated;
- CFG->frontpageloggedin by default shows list of available courses;
- There is separate item to display course search box
- CFG->maxcoursesincombo is deprecated
- CFG->maxcategorydepth changed default value to 2 since we have AJAX loading now
- FRONTPAGECOURSELIMIT is transformed to CFG->frontpagecourselimit

c
2013-04-16 15:00:55 +10:00
Marina Glancy 5f79b34b5e MDL-38682 removed auto page type, created issue MDL-39045 to address this 2013-04-09 16:16:21 +10:00
Marina Glancy 9dd85edf02 MDL-38682 Allow configuring blocks for courses lists pages
Also fixed block configuration form error when pagetype string does not exist (for course- pages)
2013-04-09 13:24:31 +10:00
Aparup Banerjee 37240ce5c6 Merge branch 'wip-MDL-38708-master' of git://github.com/marinaglancy/moodle
Conflicts:
	version.php
2013-04-04 15:07:01 +08:00
Damyon Wiese 200571507f Merge branch 'wip-MDL-37009-master' of git://github.com/marinaglancy/moodle 2013-04-04 11:22:20 +08:00
Damyon Wiese 9ab0aece49 Merge branch 'MDL-38700-master' of git://github.com/danpoltawski/moodle
Conflicts:
	course/tests/courselib_test.php
2013-04-02 12:48:08 +08:00
Marina Glancy d1f8c1bd62 MDL-38708 Added course overview files (most often images) to courses 2013-04-02 11:08:21 +11:00
Marina Glancy 09ae7ee031 MDL-37009 Deprecated all courses display functions that are not used any more
print_my_moodle(), print_remote_course(),
  print_remote_host(), print_whole_category_list(), print_category_info(), get_course_category_tree(),
  print_courses(), print_course(), get_category_courses_array(), get_category_courses_array_recursively()
2013-04-02 10:58:24 +11:00
Marina Glancy 8e57a6df6d MDL-37009 Display courses and categories tree on /course/index.php using new renderer
Also /course/category.php
2013-04-02 10:54:49 +11:00
Marina Glancy a8d683ca8e MDL-37009 function print_course_search() is moved to deprecatedlib.php 2013-04-02 10:54:48 +11:00
Marina Glancy f4b571ab2b MDL-37009 function print_course_search() is moved to course renderer 2013-04-02 10:54:48 +11:00
Aparup Banerjee 3a7e4a80ad MDL-38564 fixed whitespace 2013-03-26 17:22:22 +08:00
Aparup Banerjee be0eacf883 Merge branch 'MDL-38564-master' of git://github.com/ankitagarwal/moodle 2013-03-26 17:20:01 +08:00
Ankit Agarwal bf6b3c7a8a MDL-38564 Adding unit tests for the functions compare_activities_by_time_asc() and compare_activities_by_time_desc() 2013-03-26 16:12:01 +08:00
Charles Fulton bb1592c860 MDL-38700 course: only change visibility if a module moves to a different section 2013-03-26 15:03:33 +08:00
Marina Glancy 4e53188a4b MDL-38147 bug fix, changed usage of non-existing function 2013-03-26 16:17:34 +11:00
Marina Glancy eabbfa82d3 MDL-38147 Improvements to caching of course categories, coursecat::get_children() improvements
- Course categories caches are purged by event now
- session cache has additional 10 minutes ttl to clear itself and accomodate for permission changes that do not trigger event purging
- additional request-level cache for coursecat::get()
- We store only children of one category in one cache key
- Function coursecat::get_children() can return results sorted and/or paginated. Added tests
2013-03-25 13:23:15 +11:00
Marina Glancy 8db5dcb7cd MDL-38147 deprecated get_child_categories(), change usage to coursecat 2013-03-25 13:22:56 +11:00
Marina Glancy 9bad61dbfe MDL-38147 deprecated create_course_category(), change usage to coursecat. Also avoid direct DB update of table course_categories
changed to usage of
- coursecat::create()
- coursecat::update()
2013-03-25 13:22:26 +11:00
Marina Glancy 2d8a275bab MDL-38147 deprecated get_course_category(), change usage to coursecat 2013-03-25 13:21:20 +11:00
Marina Glancy 6e1d1ee0e7 MDL-38147 deprecated move_category(), course_category_hide(), course_category_show(), change usage to coursecat
All usages in core replaced with:
- coursecat::change_parent()
- coursecat::hide()
- coursecat::show()
2013-03-25 13:21:09 +11:00
Marina Glancy deb65cedc4 MDL-38147 deprecated category_delete_move(), category_delete_full(), change usage to coursecat 2013-03-25 13:21:04 +11:00
Marina Glancy 4e0b6025ad MDL-38147 deprecated make_categories_list(), change usage to coursecat 2013-03-25 13:20:46 +11:00
Jerome Mouneyrac 80fe0c1983 MDL-37079 switch the modedit.php functions into course/modedit.php 2013-03-18 14:41:38 +08:00
Jerome Mouneyrac 7cb0ea2c37 MDL-37079 remove TODO, add . in comments 2013-03-18 14:41:37 +08:00
Jerome Mouneyrac 7bf4f6e999 MDL-37079 Added many assertEquals + generic test function (easy to test new module) + now process next advanced grading screens 2013-03-18 14:41:36 +08:00
Jerome Mouneyrac dd5d933f30 MDL-37079 create/update_module() 2013-03-18 14:41:35 +08:00
Eloy Lafuente (stronk7) 9515c34ee6 Merge branch 'wip-MDL-30669-master' of git://github.com/abgreeve/moodle 2013-02-26 09:46:13 +01:00
Adrian Greeve 3dd204b1e6 MDL-30669 - blocks: Added a warning when deleting blocks that have multiple displays set.
Also added a fix to the function course_page_type_list(). It was making a call to
get_context_info_array() which will generate an error if $currentcontext is not set.
2013-02-26 10:21:37 +08:00
Eloy Lafuente (stronk7) ca1774aea4 Merge branch 'wip-MDL-34298-m25' of git://github.com/samhemelryk/moodle 2013-02-20 00:45:50 +01:00
Sam Hemelryk 79a809ba44 MDL-34298 course: fixed course search output validation issue 2013-02-19 11:03:58 +13:00
Marina Glancy 9ecb50e6e3 MDL-33774 instead of checking that activity is label we check that it has view url 2013-02-14 19:46:19 +11:00
Damyon Wiese 6904688967 Merge branch 'MDL-37654_master' of https://github.com/markn86/moodle 2013-02-12 13:09:18 +08:00
Mark Nelson 9a9cb74118 MDL-37654 core_course: ensure exceptions return static error codes for debugging purposes 2013-02-06 12:10:10 +08:00
Dan Poltawski 9cf44c32b5 Merge branch 'wip-MDL-37572-m25' of git://github.com/samhemelryk/moodle 2013-02-05 15:25:08 +08:00