From ffdee5e9db2f8f685a88b29f74f189da730eeacb Mon Sep 17 00:00:00 2001 From: Laurent David Date: Mon, 3 Feb 2025 18:52:53 +0100 Subject: [PATCH] MDL-81155 report_log: Final deprecation for $grouplist * The grouplist has been introduced in MDL-41465 and is not used anymore since the patch in MDL-80565. --- .upgradenotes/MDL-81155-2025020317513360.yml | 6 ++++++ report/log/classes/renderable.php | 8 -------- 2 files changed, 6 insertions(+), 8 deletions(-) create mode 100644 .upgradenotes/MDL-81155-2025020317513360.yml diff --git a/.upgradenotes/MDL-81155-2025020317513360.yml b/.upgradenotes/MDL-81155-2025020317513360.yml new file mode 100644 index 00000000000..e151ec37b15 --- /dev/null +++ b/.upgradenotes/MDL-81155-2025020317513360.yml @@ -0,0 +1,6 @@ +issueNumber: MDL-81155 +notes: + report_log: + - message: >- + Support for the $grouplist public member in the report_log_renderable class has been removed. + type: removed diff --git a/report/log/classes/renderable.php b/report/log/classes/renderable.php index 8a223553a42..9e30c3c8b66 100644 --- a/report/log/classes/renderable.php +++ b/report/log/classes/renderable.php @@ -96,13 +96,6 @@ class report_log_renderable implements renderable { /** @var array Index of delegated sections (indexed by component and itemid) */ protected $delegatedbycm; - /** - * @var array group ids - * @deprecated since Moodle 4.4 - please do not use this public property - * @todo MDL-81155 remove this property as it is not used anymore. - */ - public $grouplist; - /** @var bool if the page is activity page */ public $isactivitypage; @@ -447,7 +440,6 @@ class report_log_renderable implements renderable { if (!empty($cgroups)) { $grouplist = array_column($cgroups, 'name', 'id'); } - $this->grouplist = $grouplist; // Keep compatibility with MDL-41465. return $grouplist; }