Merge branch 'MDL-82554-MOODLE_404_STABLE' of https://github.com/micaherne/moodle into MOODLE_404_STABLE

2024-07-25 08:50:32 +07:00
parent 3da6a04461 da95f8d083
commit ffc32f80a5
2 changed files with 30 additions and 1 deletions
@@ -2023,6 +2023,35 @@ class questionlib_test extends \advanced_testcase {
        }
    }

+    /**
+     * Test that question_has_capability_on does not fail when passed an object with a null
+     * createdby property.
+     */
+    public function test_question_has_capability_on_object_with_null_createdby(): void {
+        $this->resetAfterTest();
+        $generator = $this->getDataGenerator();
+        $user = $generator->create_user();
+        $category = $generator->create_category();
+        $context = \context_coursecat::instance($category->id);
+
+        $role = $generator->create_role();
+        role_assign($role, $user->id, $context->id);
+        assign_capability('moodle/question:editmine', CAP_ALLOW, $role, $context->id);
+
+        $this->setUser($user);
+
+        $fakequestion = (object) [
+            'contextid' => $context->id,
+            'createdby' => null,
+        ];
+
+        $this->assertFalse(question_has_capability_on($fakequestion, 'edit'));
+
+        $fakequestion->createdby = $user->id;
+
+        $this->assertTrue(question_has_capability_on($fakequestion, 'edit'));
+    }
+
    /**
     * Test of question_categorylist function.
     *