L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-78993 theme: Remove $CFG->svgicons

Browse Source 
The $CFG->svgicons setting was introduced in Moodle 2.4 due to incomplete
SVG support in certain web browsers.
The landscape has evolved significantly since then, and all modern browsers
now handle SVG files correctly.
The $CFG->svgicons settings has been removed and the supports_svg() method
has been updated with currently supported browsers (IE support was removed
in Moodle 3.10).
This commit is contained in:
Sara Arjona
2023-09-12 15:28:03 +02:00
parent b4c6ed3650
commit ff844ab7bd
13 changed files with 30 additions and 479 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/classes/useragent.php
+3 -16
View File
@@ -958,26 +958,13 @@ class core_useragent {
* @return bool
*/
public static function supports_svg() {
// IE 5 - 8 don't support SVG at all.
$instance = self::instance();
if ($instance->supportssvg === null) {
if ($instance->useragent === false) {
// Can't be sure, just say no.
$instance->supportssvg = false;
} else if (self::check_ie_version('0') and !self::check_ie_version('9')) {
// IE < 9 doesn't support SVG. Say no.
$instance->supportssvg = false;
} else if (self::is_ie() and !self::check_ie_version('10') and self::check_ie_compatibility_view()) {
// IE 9 Compatibility View doesn't support SVG. Say no.
$instance->supportssvg = false;
} else if (preg_match('#Android +[0-2]\.#', $instance->useragent)) {
// Android < 3 doesn't support SVG. Say no.
$instance->supportssvg = false;
} else if (self::is_opera()) {
// Opera 12 still does not support SVG well enough. Say no.
if (preg_match('#Android +[0-2]\.#', $instance->useragent)) {
// Android < 3 doesn't support SVG.
$instance->supportssvg = false;
} else {
// Presumed fine.
// With widespread SVG support in modern browsers, default to returning true (even when useragent is false).
$instance->supportssvg = true;
}
}