From 54908ae9071cc2fbcae381d61455621f941a13f1 Mon Sep 17 00:00:00 2001
From: Tim Hunt <T.J.Hunt@open.ac.uk>
Date: Wed, 29 Jan 2020 18:34:39 +0000
Subject: [PATCH] MDL-67830 quiz: notice in grade details redirect script

---
 mod/quiz/attemptlib.php | 39 ++++++++++++++++++++++++---------------
 mod/quiz/grade.php      |  1 +
 2 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/mod/quiz/attemptlib.php b/mod/quiz/attemptlib.php
index 0e7d1286b35..69dd30e5778 100644
--- a/mod/quiz/attemptlib.php
+++ b/mod/quiz/attemptlib.php
@@ -576,25 +576,12 @@ class quiz_attempt {
      *      of the state of each question. Else just set up the basic details of the attempt.
      */
     public function __construct($attempt, $quiz, $cm, $course, $loadquestions = true) {
-        global $DB;
-
         $this->attempt = $attempt;
         $this->quizobj = new quiz($quiz, $cm, $course);
 
-        if (!$loadquestions) {
-            return;
+        if ($loadquestions) {
+            $this->load_questions();
         }
-
-        $this->quba = question_engine::load_questions_usage_by_activity($this->attempt->uniqueid);
-        $this->slots = $DB->get_records('quiz_slots',
-                array('quizid' => $this->get_quizid()), 'slot',
-                'slot, id, requireprevious, questionid, includingsubcategories');
-        $this->sections = array_values($DB->get_records('quiz_sections',
-                array('quizid' => $this->get_quizid()), 'firstslot'));
-
-        $this->link_sections_and_slots();
-        $this->determine_layout();
-        $this->number_questions();
     }
 
     /**
@@ -643,6 +630,28 @@ class quiz_attempt {
         return quiz_attempt_state_name($state);
     }
 
+    /**
+     * This method can be called later if the object was constructed with $loadqusetions = false.
+     */
+    public function load_questions() {
+        global $DB;
+
+        if (isset($this->quba)) {
+            throw new coding_exception('This quiz attempt has already had the questions loaded.');
+        }
+
+        $this->quba = question_engine::load_questions_usage_by_activity($this->attempt->uniqueid);
+        $this->slots = $DB->get_records('quiz_slots',
+                array('quizid' => $this->get_quizid()), 'slot',
+                'slot, id, requireprevious, questionid, includingsubcategories');
+        $this->sections = array_values($DB->get_records('quiz_sections',
+                array('quizid' => $this->get_quizid()), 'firstslot'));
+
+        $this->link_sections_and_slots();
+        $this->determine_layout();
+        $this->number_questions();
+    }
+
     /**
      * Let each slot know which section it is part of.
      */
diff --git a/mod/quiz/grade.php b/mod/quiz/grade.php
index f7ca5cbacb4..970aa6f5543 100644
--- a/mod/quiz/grade.php
+++ b/mod/quiz/grade.php
@@ -81,6 +81,7 @@ if ($userid) {
     if ($attempt) {
         $attemptobj = new quiz_attempt($attempt, $quiz, $cm, $course, false);
         if ($attemptobj->is_review_allowed()) {
+            $attemptobj->load_questions();
             redirect($attemptobj->review_url());
         }
     }