From fefa34120a6e333019b2548ca464f7d35e8eab45 Mon Sep 17 00:00:00 2001 From: David Monllao Date: Fri, 6 Oct 2017 18:38:10 +0200 Subject: [PATCH] MDL-59063 analytics: Finished courses can't be used for prediction --- lang/en/moodle.php | 1 + lib/classes/analytics/target/course_dropout.php | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/lang/en/moodle.php b/lang/en/moodle.php index e36d9704e5a..4ce65d91b1f 100644 --- a/lang/en/moodle.php +++ b/lang/en/moodle.php @@ -292,6 +292,7 @@ $string['counteditems'] = '{$a->count} {$a->items}'; $string['country'] = 'Country'; $string['course'] = 'Course'; $string['courseadministration'] = 'Course administration'; +$string['coursealreadyfinished'] = 'Course already finished'; $string['courseapprovedemail'] = 'Your requested course, {$a->name}, has been approved and you have been made a {$a->teacher}. To access your new course, go to {$a->url}'; $string['courseapprovedemail2'] = 'Your requested course, {$a->name}, has been approved. To access your new course, go to {$a->url}'; $string['courseapprovedfailed'] = 'Failed to save the course as approved!'; diff --git a/lib/classes/analytics/target/course_dropout.php b/lib/classes/analytics/target/course_dropout.php index 9787b815d97..b44ec4d34ae 100644 --- a/lib/classes/analytics/target/course_dropout.php +++ b/lib/classes/analytics/target/course_dropout.php @@ -158,6 +158,11 @@ class course_dropout extends \core_analytics\local\target\binary { return get_string('coursetoolong', 'analytics'); } + // Finished courses can not be used to get predictions. + if (!$fortraining && $course->is_finished()) { + return get_string('coursealreadyfinished'); + } + // Ongoing courses data can not be used to train. if ($fortraining && !$course->is_finished()) { return get_string('coursenotyetfinished');