From fe575d8215bb0278644687672a61a77c9244c5ed Mon Sep 17 00:00:00 2001 From: Eloy Lafuente Date: Mon, 1 Nov 2010 15:52:18 +0000 Subject: [PATCH] NOBUG: Added note to avoid forgetting it --- backup/controller/backup_controller.class.php | 2 ++ backup/controller/restore_controller.class.php | 2 ++ 2 files changed, 4 insertions(+) diff --git a/backup/controller/backup_controller.class.php b/backup/controller/backup_controller.class.php index 68927ad3ba4..8699fbc68fc 100644 --- a/backup/controller/backup_controller.class.php +++ b/backup/controller/backup_controller.class.php @@ -157,6 +157,8 @@ class backup_controller extends backup implements loggable { // TODO: Check it's a correct status $this->status = $status; // Ensure that, once set to backup::STATUS_AWAITING, controller is stored in DB + // Note: never save_controller() after STATUS_EXECUTING or the whole controller, + // containing all the steps will be sent to DB. 100% (monster) useless. if ($status == backup::STATUS_AWAITING) { $this->save_controller(); $this->logger = self::load_controller($this->backupid)->logger; // wakeup loggers diff --git a/backup/controller/restore_controller.class.php b/backup/controller/restore_controller.class.php index 8e3535c82be..78fb4e67f3e 100644 --- a/backup/controller/restore_controller.class.php +++ b/backup/controller/restore_controller.class.php @@ -153,6 +153,8 @@ class restore_controller extends backup implements loggable { // TODO: Check it's a correct status $this->status = $status; // Ensure that, once set to backup::STATUS_AWAITING | STATUS_NEED_PRECHECK, controller is stored in DB + // Note: never save_controller() after STATUS_EXECUTING or the whole controller, + // containing all the steps will be sent to DB. 100% (monster) useless. if ($status == backup::STATUS_AWAITING || $status == backup::STATUS_NEED_PRECHECK) { $this->save_controller(); $this->logger = self::load_controller($this->restoreid)->logger; // wakeup loggers