From fe1dd7ebde36ed0a97b7b099a0977a9174cc5d9b Mon Sep 17 00:00:00 2001 From: Sam Hemelryk Date: Mon, 7 Feb 2011 10:46:50 +0800 Subject: [PATCH] dml-sqlsrv MDL-26025 Removed use of property to track rownumber field in favor of always unsetting it --- lib/dml/sqlsrv_native_moodle_recordset.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/dml/sqlsrv_native_moodle_recordset.php b/lib/dml/sqlsrv_native_moodle_recordset.php index 3b7e36c3756..8ee18fdbf39 100644 --- a/lib/dml/sqlsrv_native_moodle_recordset.php +++ b/lib/dml/sqlsrv_native_moodle_recordset.php @@ -32,7 +32,6 @@ class sqlsrv_native_moodle_recordset extends moodle_recordset { protected $rsrc; protected $current; - protected $hasrownumber = null; public function __construct($rsrc) { $this->rsrc = $rsrc; @@ -45,12 +44,7 @@ class sqlsrv_native_moodle_recordset extends moodle_recordset { private function fetch_next() { if ($row = sqlsrv_fetch_array($this->rsrc, SQLSRV_FETCH_ASSOC)) { - if ($this->hasrownumber === null) { - $this->hasrownumber = array_key_exists('sqlsrvrownumber', $row); - } - if ($this->hasrownumber) { - unset($row['sqlsrvrownumber']); - } + unset($row['sqlsrvrownumber']); $row = array_change_key_case($row, CASE_LOWER); } return $row;