MDL-76867 core: Add plugintype_supports_disabling to plugininfo

This commit is contained in:
Andrew Nicols
2023-03-14 08:34:42 +08:00
parent 6809289cf4
commit fdb1df2bfd
27 changed files with 240 additions and 0 deletions
@@ -27,6 +27,10 @@ use moodle_url;
*/
class tiny extends \core\plugininfo\base {
public static function plugintype_supports_disabling(): bool {
return true;
}
/**
* These subplugins can be uninstalled.
*
@@ -94,6 +98,53 @@ class tiny extends \core\plugininfo\base {
* @return null|string the settings section name.
*/
public function get_settings_section_name(): ?string {
if (!file_exists($this->full_path('settings.php'))) {
return null;
}
return "tiny_{$this->name}_settings";
}
public static function get_enabled_plugins(): array {
$pluginmanager = \core_plugin_manager::instance();
$plugins = $pluginmanager->get_installed_plugins('tiny');
if (!$plugins) {
return [];
}
// Filter to return only enabled plugins.
$enabled = [];
foreach (array_keys($plugins) as $pluginname) {
$disabled = get_config("tiny_{$pluginname}", 'disabled');
if (empty($disabled)) {
$enabled[$pluginname] = $pluginname;
}
}
return $enabled;
}
public static function enable_plugin(string $plugin, int $enabled): bool {
$pluginname = "tiny_{$plugin}";
$oldvalue = !empty(get_config($pluginname, 'disabled'));
$disabled = empty($enabled);
$haschanged = false;
// Only set value if there is no config setting or if the value is different from the previous one.
if (!$oldvalue && $disabled) {
set_config('disabled', $disabled, $pluginname);
$haschanged = true;
} else if ($oldvalue && !$disabled) {
unset_config('disabled', $pluginname);
$haschanged = true;
}
if ($haschanged) {
add_to_config_log('disabled', $oldvalue, $disabled, $pluginname);
\core_plugin_manager::reset_caches();
}
return $haschanged;
}
}
@@ -0,0 +1,74 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
declare(strict_types=1);
namespace editor_tiny\plugininfo;
use advanced_testcase;
/**
* Unit tests for the editor_tiny\tiny plugininfo class.
*
* @package editor_tiny
* @covers \editor_tiny\plugininfo\tiny
* @copyright 2023 Andrew Lyons <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class tiny_test extends advanced_testcase {
/**
* Uninstall is allowed of TinyMCE plugins.
*
* @covers ::is_uninstall_allowed
*/
public function test_is_uninstall_allowed(): void {
$instance = new tiny();
$this->assertTrue($instance->is_uninstall_allowed());
}
/**
* Check the manage URL.
*
* @covers ::get_manage_url
*/
public function test_get_manage_url(): void {
$this->assertInstanceOf(\moodle_url::class, tiny::get_manage_url());
}
/**
* Test the get_enabled_plugins method.
*
* @covers ::get_enabled_plugin
*/
public function test_get_enabled_plugins(): void {
$this->resetAfterTest();
$plugins = tiny::get_enabled_plugins();
$this->assertArrayHasKey('recordrtc', $plugins);
$this->assertArrayHasKey('media', $plugins);
$this->assertArrayHasKey('autosave', $plugins);
$this->assertArrayHasKey('h5p', $plugins);
// Disable a plugin.
tiny::enable_plugin('h5p', 0);
$plugins = tiny::get_enabled_plugins();
$this->assertArrayHasKey('recordrtc', $plugins);
$this->assertArrayHasKey('media', $plugins);
$this->assertArrayHasKey('autosave', $plugins);
$this->assertArrayNotHasKey('h5p', $plugins);
}
}