L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup

Browse Source
This commit is contained in:
skodak
2009-06-13 18:34:43 +00:00
parent a8f3a651c0
commit fc29e51b2d
20 changed files with 25 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/import.php
+1 -4
View File
@@ -248,10 +248,7 @@
}
$newitem->required = intval($item['@']['REQUIRED']);
$newitem->position = $position;
if (!$DB->insert_record('feedback_item', $newitem)) {
$error->stat = false;
$error->msg[] = 'item ('.$newitem->name.') not imported';
}
$DB->insert_record('feedback_item', $newitem);
}
return $error;
}
mod/feedback/mapcourse.php
+2 -2
View File
@@ -52,8 +52,8 @@
$sql = "SELECT id, feedbackid
FROM {feedback_sitecourse_map}
WHERE feedbackid = ? AND courseid = ?";
if (!$DB->get_records_sql($sql, array($map->feedbackid, $map->courseid)) && !$DB->insert_record('feedback_sitecourse_map', $map)) {
print_error('cannotmapfeedback', 'feedback');
if (!$DB->get_records_sql($sql, array($map->feedbackid, $map->courseid))) {
$DB->insert_record('feedback_sitecourse_map', $map);
}
}
mod/forum/lib.php
+1 -3
View File
@@ -573,9 +573,7 @@ function forum_cron() {
$queue->discussionid = $discussion->id;
$queue->postid = $post->id;
$queue->timemodified = $post->created;
if (!$DB->insert_record('forum_queue', $queue)) {
mtrace("Error: mod/forum/cron.php: Could not queue for digest mail for id $post->id to user $userto->id ($userto->email) .. not trying again.");
}
$DB->insert_record('forum_queue', $queue);
continue;
}
mod/lesson/action/continue.php
+1 -3
View File
@@ -508,9 +508,7 @@
$branch->flag = $branchflag;
$branch->timeseen = time();
if (!$DB->insert_record("lesson_branch", $branch)) {
print_error("Error: could not insert row into lesson_branch table");
}
$DB->insert_record("lesson_branch", $branch);
// this is called when jumping to random from a branch table
if($newpageid == LESSON_UNSEENBRANCHPAGE) {
mod/quiz/lib.php
+1 -3
View File
@@ -1058,9 +1058,7 @@ function quiz_after_add_or_update($quiz) {
$feedback->feedbacktext = $quiz->feedbacktext[$i];
$feedback->mingrade = $quiz->feedbackboundaries[$i];
$feedback->maxgrade = $quiz->feedbackboundaries[$i - 1];
if (!$DB->insert_record('quiz_feedback', $feedback, false)) {
return "Could not save quiz feedback.";
}
$DB->insert_record('quiz_feedback', $feedback, false);
}
// Update the events relating to this quiz.