MDL-38055 course: fixed double encoding of title properties
Conflicts: lib/navigationlib.php
This commit is contained in:
@@ -2358,6 +2358,7 @@ class global_navigation extends navigation_node {
|
||||
|
||||
$issite = ($course->id == $SITE->id);
|
||||
$shortname = format_string($course->shortname, true, array('context' => $coursecontext));
|
||||
$fullname = format_string($course->fullname, true, array('context' => $coursecontext));
|
||||
|
||||
if ($issite) {
|
||||
$parent = $this;
|
||||
@@ -2396,7 +2397,9 @@ class global_navigation extends navigation_node {
|
||||
$coursenode = $parent->add($shortname, $url, self::TYPE_COURSE, $shortname, $course->id);
|
||||
$coursenode->nodetype = self::NODETYPE_BRANCH;
|
||||
$coursenode->hidden = (!$course->visible);
|
||||
$coursenode->title(format_string($course->fullname, true, array('context' => context_course::instance($course->id))));
|
||||
// We need to decode &'s here as they will have been added by format_string above and attributes will be encoded again
|
||||
// later.
|
||||
$coursenode->title(str_replace('&', '&', $fullname));
|
||||
if (!$forcegeneric) {
|
||||
$this->addedcourses[$course->id] = $coursenode;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user