From d8e6e58ec5c4751a9f4c43b6c65fa565966c4a98 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Tue, 28 Aug 2012 14:16:15 +0200 Subject: [PATCH] MDL-34192 mod_assign: prevent ambiguous column use for Oracle. Credit goes to Raymond Antonio from NetSpot. --- mod/assign/gradingtable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/assign/gradingtable.php b/mod/assign/gradingtable.php index fb5e4ffb9de..40bed663228 100644 --- a/mod/assign/gradingtable.php +++ b/mod/assign/gradingtable.php @@ -88,7 +88,7 @@ class assign_grading_table extends table_sql implements renderable { $params['assignmentid1'] = (int)$this->assignment->get_instance()->id; $params['assignmentid2'] = (int)$this->assignment->get_instance()->id; - $fields = user_picture::fields('u') . ', u.id as userid, u.firstname as firstname, u.lastname as lastname, '; + $fields = user_picture::fields('u') . ', u.id as userid, '; $fields .= 's.status as status, s.id as submissionid, s.timecreated as firstsubmission, s.timemodified as timesubmitted, '; $fields .= 'g.id as gradeid, g.grade as grade, g.timemodified as timemarked, g.timecreated as firstmarked, g.mailed as mailed, g.locked as locked'; $from = '{user} u LEFT JOIN {assign_submission} s ON u.id = s.userid AND s.assignment = :assignmentid1' .