diff --git a/lang/en/reportbuilder.php b/lang/en/reportbuilder.php index 7689942c182..10dc96b4de5 100644 --- a/lang/en/reportbuilder.php +++ b/lang/en/reportbuilder.php @@ -72,6 +72,7 @@ $string['conditionsreset'] = 'Conditions reset'; $string['coursefullnamewithlink'] = 'Course full name with link'; $string['courseidnumberewithlink'] = 'Course ID number with link'; $string['courseshortnamewithlink'] = 'Course short name with link'; +$string['courseselect'] = 'Select course'; $string['customfieldcolumn'] = '{$a}'; $string['customreports'] = 'Custom reports'; $string['deleteaudience'] = 'Delete audience \'{$a}\''; @@ -180,7 +181,6 @@ $string['resetconditionsconfirm'] = 'Are you sure you want to reset all conditio $string['selectacondition'] = 'Select a condition'; $string['selectafilter'] = 'Select a filter'; $string['selectareportsource'] = 'Select a report source'; -$string['selectcourses'] = 'Select courses'; $string['showhide'] = 'Show/hide \'{$a}\''; $string['sorting'] = 'Sorting'; $string['sorting_help'] = 'Sorting defines the initial sort order of columns in the report. The order can be reversed by toggling the Up/down icon. Users can then define their own sort order by clicking on a column name.'; diff --git a/reportbuilder/classes/local/entities/course.php b/reportbuilder/classes/local/entities/course.php index a2f567a303d..982b3a08a41 100644 --- a/reportbuilder/classes/local/entities/course.php +++ b/reportbuilder/classes/local/entities/course.php @@ -327,7 +327,7 @@ class course extends base { $filters[] = (new filter( course_selector::class, 'courseselector', - new lang_string('courses'), + new lang_string('courseselect', 'core_reportbuilder'), $this->get_entity_name(), "{$tablealias}.id" )) diff --git a/reportbuilder/classes/local/filters/course_selector.php b/reportbuilder/classes/local/filters/course_selector.php index 8031612a92f..21060b24a83 100644 --- a/reportbuilder/classes/local/filters/course_selector.php +++ b/reportbuilder/classes/local/filters/course_selector.php @@ -36,10 +36,12 @@ class course_selector extends base { * @param MoodleQuickForm $mform */ public function setup_form(MoodleQuickForm $mform): void { + $operatorlabel = get_string('filterfieldvalue', 'core_reportbuilder', $this->get_header()); $options = [ 'multiple' => true, ]; - $mform->addElement('course', $this->name . '_values', get_string('selectcourses', 'core_reportbuilder'), $options) + + $mform->addElement('course', $this->name . '_values', $operatorlabel, $options) ->setHiddenLabel(true); }