From faa963ba9af470e6cc278567e8cfdd6ea25278b9 Mon Sep 17 00:00:00 2001 From: Brian Barnes Date: Thu, 26 Jun 2014 11:59:40 +1200 Subject: [PATCH] MDL-46144 core_calendar:Fixed label linking in calendar --- calendar/renderer.php | 8 +++----- lang/en/calendar.php | 5 +++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/calendar/renderer.php b/calendar/renderer.php index 2a86b03d6ab..f0660fae133 100644 --- a/calendar/renderer.php +++ b/calendar/renderer.php @@ -259,8 +259,7 @@ class core_calendar_renderer extends plugin_renderer_base { if (calendar_user_can_add_event($calendar->course)) { $output .= $this->add_event_button($calendar->course->id, 0, 0, 0, $calendar->time); } - //$output .= html_writer::tag('label', get_string('dayview', 'calendar'), array('for'=>'cal_course_flt_jump')); - $output .= $this->course_filter_selector($returnurl, get_string('dayview', 'calendar')); + $output .= $this->course_filter_selector($returnurl, get_string('dayviewfor', 'calendar')); $output .= html_writer::end_tag('div'); // Controls $output .= html_writer::tag('div', calendar_top_controls('day', array('id' => $calendar->courseid, 'time' => $calendar->time)), array('class'=>'controls')); @@ -468,7 +467,7 @@ class core_calendar_renderer extends plugin_renderer_base { if (calendar_user_can_add_event($calendar->course)) { $output .= $this->add_event_button($calendar->course->id, 0, 0, 0, $calendar->time); } - $output .= get_string('detailedmonthview', 'calendar').': '.$this->course_filter_selector($returnurl); + $output .= $this->course_filter_selector($returnurl, get_string('detailedmonthviewfor', 'calendar')); $output .= html_writer::end_tag('div', array('class'=>'header')); // Controls $output .= html_writer::tag('div', calendar_top_controls('month', array('id' => $calendar->courseid, 'time' => $calendar->time)), array('class' => 'controls')); @@ -691,8 +690,7 @@ class core_calendar_renderer extends plugin_renderer_base { if (calendar_user_can_add_event($calendar->course)) { $output .= $this->add_event_button($calendar->course->id); } - $output .= html_writer::tag('label', get_string('upcomingevents', 'calendar'), array('for'=>'cal_course_flt_jump')); - $output .= $this->course_filter_selector($returnurl); + $output .= $this->course_filter_selector($returnurl, get_string('upcomingeventsfor', 'calendar')); $output .= html_writer::end_tag('div'); if ($events) { diff --git a/lang/en/calendar.php b/lang/en/calendar.php index 44f9b25c8fe..5fa7b1e710a 100644 --- a/lang/en/calendar.php +++ b/lang/en/calendar.php @@ -46,13 +46,13 @@ $string['courseevents'] = 'Course events'; $string['courses'] = 'Courses'; $string['customexport'] = 'Custom range ({$a->timestart} - {$a->timeend})'; $string['daily'] = 'Daily'; -$string['dayview'] = 'Day view'; +$string['dayviewfor'] = 'Day view for:'; $string['dayviewtitle'] = 'Day view: {$a}'; $string['daywithnoevents'] = 'There are no events this day.'; $string['default'] = 'Default'; $string['deleteevent'] = 'Delete event'; $string['deleteevents'] = 'Delete events'; -$string['detailedmonthview'] = 'Detailed month view'; +$string['detailedmonthviewfor'] = 'Detailed month view for:'; $string['detailedmonthviewtitle'] = 'Detailed month view: {$a}'; $string['durationminutes'] = 'Duration in minutes'; $string['durationnone'] = 'Without duration'; @@ -199,6 +199,7 @@ $string['typegroup'] = 'Group event'; $string['typesite'] = 'Site event'; $string['typeuser'] = 'User event'; $string['upcomingevents'] = 'Upcoming events'; +$string['upcomingeventsfor'] = 'Upcoming events for:'; $string['urlforical'] = 'URL for iCalendar export, for subscribing to calendar'; $string['user'] = 'User'; $string['userevent'] = 'User event';