From 600cd22b0fc476d47bfd0b963948122b8bdc33ae Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Tue, 15 Feb 2022 16:05:34 +0000 Subject: [PATCH] MDL-73745 reportbuilder: check for presence of active column headers. --- reportbuilder/classes/table/custom_report_table.php | 2 +- reportbuilder/classes/table/custom_report_table_view.php | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/reportbuilder/classes/table/custom_report_table.php b/reportbuilder/classes/table/custom_report_table.php index c689c91d024..d393460f5bb 100644 --- a/reportbuilder/classes/table/custom_report_table.php +++ b/reportbuilder/classes/table/custom_report_table.php @@ -218,7 +218,7 @@ class custom_report_table extends base_report_table { * * @return column[] */ - private function get_active_columns(): array { + protected function get_active_columns(): array { return $this->report->get_active_columns(); } diff --git a/reportbuilder/classes/table/custom_report_table_view.php b/reportbuilder/classes/table/custom_report_table_view.php index 3fca2dbf005..c257298e59d 100644 --- a/reportbuilder/classes/table/custom_report_table_view.php +++ b/reportbuilder/classes/table/custom_report_table_view.php @@ -36,6 +36,11 @@ class custom_report_table_view extends custom_report_table { * Override printed headers, to use those of grandparent class */ public function print_headers() { + $columns = $this->get_active_columns(); + if (empty($columns)) { + return; + } + base_report_table::print_headers(); }