From fa01f2b45aa28bdeba4e52c4f8f4da8fa69935b7 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Wed, 31 Dec 2014 15:12:34 +0000
Subject: [PATCH] MDL-35155 dml: add unit test which exposes substr problem

Previously, when using parameters, substring broke on mssql.
---
 lib/dml/tests/dml_test.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/dml/tests/dml_test.php b/lib/dml/tests/dml_test.php
index e4a82b916cb..7ab59df4584 100644
--- a/lib/dml/tests/dml_test.php
+++ b/lib/dml/tests/dml_test.php
@@ -4026,6 +4026,10 @@ class core_dml_testcase extends database_driver_testcase {
         } catch (moodle_exception $e) {
             $this->assertInstanceOf('coding_exception', $e);
         }
+
+        $sql = "SELECT id, ".$DB->sql_substr("name", ":param1 + 1")." AS name FROM {{$tablename}}";
+        $record = $DB->get_record_sql($sql, array('param1' => 4));
+        $this->assertEquals(substr($string, 5-1), $record->name);
     }
 
     public function test_sql_length() {