From f9870842bddb645ff025f813eda1601c5009d6fa Mon Sep 17 00:00:00 2001
From: Sam Hemelryk <sam@moodle.com>
Date: Fri, 30 Nov 2012 14:45:05 +1300
Subject: [PATCH] MDL-36939 cache: instance form validation now handles errors
 properly

---
 cache/forms.php | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/cache/forms.php b/cache/forms.php
index 533f1f8713c..542e7a0046c 100644
--- a/cache/forms.php
+++ b/cache/forms.php
@@ -101,7 +101,13 @@ class cachestore_addinstance_form extends moodleform {
         }
 
         if (method_exists($this, 'configuration_validation')) {
-            $errors = $this->configuration_validation($data, $files);
+            $newerrors = $this->configuration_validation($data, $files, $errors);
+            // We need to selectiviliy merge here
+            foreach ($newerrors as $element => $error) {
+                if (!array_key_exists($element, $errors)) {
+                    $errors[$element] = $error;
+                }
+            }
         }
 
         return $errors;