From f8587005cbebce5eb8f8f9fd2c68d9f5e1be1508 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Thu, 1 Jun 2017 14:22:35 +0100
Subject: [PATCH] MDL-57139 survey: fix promise return

---
 mod/survey/amd/src/validation.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mod/survey/amd/src/validation.js b/mod/survey/amd/src/validation.js
index 75880c2dd1a..5439e684923 100644
--- a/mod/survey/amd/src/validation.js
+++ b/mod/survey/amd/src/validation.js
@@ -49,11 +49,10 @@ define(['jquery', 'core/str', 'core/modal_factory', 'core/notification'], functi
                 if (form.find('input:radio[data-survey-default="true"]:checked').length !== 0) {
                     e.preventDefault();
                     // Display the modal error.
-                    modalPromise.then(function(modal) {
+                    return modalPromise.then(function(modal) {
                         modal.show();
-                        return;
+                        return false;
                     });
-                    return false;
                 }
 
                 return true;