MDL-60915 core_dml: fix miscellaneous incorrect recordset usage

The new recordset support for Postgres requires transactions and
will cause errors if recordsets are not closed correctly. This
commit fixes problems that were identified during unit tests, and
via some basic code analysis, across all core code. Most of these
are incorrect usage of recordset (forgetting to close them).
This commit is contained in:
sam marshall
2018-07-02 00:46:26 +02:00
committed by Eloy Lafuente (stronk7)
parent 838f07703a
commit f83d748f77
27 changed files with 70 additions and 30 deletions
+1
View File
@@ -676,6 +676,7 @@ abstract class testing_util {
$mysqlsequences[$table] = $info->auto_increment;
}
}
$rs->close();
}
foreach ($data as $table => $records) {