L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67673 phpunit: Fix the return type of template methods

Browse Source 
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...
This commit is contained in:
Eloy Lafuente (stronk7)
2020-10-21 12:45:59 +02:00
parent bdc3ad00c9
commit f6711bb394
421 changed files with 531 additions and 531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/phpunit/classes/database_driver_testcase.php
+4 -4
View File
@@ -67,7 +67,7 @@ abstract class database_driver_testcase extends base_testcase {
$this->setRunTestInSeparateProcess(false);
}
public static function setUpBeforeClass() {
public static function setUpBeforeClass(): void {
global $CFG;
parent::setUpBeforeClass();
@@ -101,7 +101,7 @@ abstract class database_driver_testcase extends base_testcase {
self::$extradb = $d;
}
protected function setUp() {
protected function setUp(): void {
global $DB;
parent::setUp();
@@ -112,7 +112,7 @@ abstract class database_driver_testcase extends base_testcase {
}
}
protected function tearDown() {
protected function tearDown(): void {
// delete all test tables
$dbman = $this->tdb->get_manager();
$tables = $this->tdb->get_tables(false);
@@ -125,7 +125,7 @@ abstract class database_driver_testcase extends base_testcase {
parent::tearDown();
}
public static function tearDownAfterClass() {
public static function tearDownAfterClass(): void {
if (self::$extradb) {
self::$extradb->dispose();
self::$extradb = null;