MDL-79351 completion: fix form_trait code smells

2023-09-14 12:24:41 +02:00
parent 9b2c445143
commit f652b769fe
5 changed files with 22 additions and 32 deletions
@@ -218,11 +218,20 @@ abstract class core_completion_edit_base_form extends moodleform {
        $this->add_action_buttons($displaycancel);
    }

+    /**
+     * Return the course module of the form, if any.
+     *
+     * @return cm_info|null
+     */
+    protected function get_cm(): ?cm_info {
+        return null;
+    }
+
    /**
     * Each module which defines definition_after_data() must call this method.
     */
    public function definition_after_data() {
-        $this->definition_after_data_completion();
+        $this->definition_after_data_completion($this->get_cm());
    }

    /**