From f58768ee9e405a09bd0a3a1e89d132e26e9dc473 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Wed, 15 Sep 2021 21:15:08 +0800 Subject: [PATCH] MDL-72701 unit tests: Fix broken @covers annotations --- backup/util/dbops/tests/restore_dbops_test.php | 2 +- badges/tests/badgeslib_test.php | 4 ++-- contentbank/tests/external/rename_content_test.php | 2 +- enrol/fee/tests/payment/service_provider_test.php | 2 +- lib/filestorage/tests/file_storage_test.php | 8 ++++---- lib/filestorage/tests/file_system_filedir_test.php | 2 +- lib/filestorage/tests/file_system_test.php | 2 +- ...{phpunit_dataset.test.php => phpunit_dataset_test.php} | 2 +- .../export/exportable_items/exportable_filearea_test.php | 2 +- .../exportable_items/exportable_stored_file_test.php | 2 +- .../export/exportable_items/exportable_textarea_test.php | 2 +- ...layer_native.php => core_media_player_native_test.php} | 2 +- .../output/icon_system/load_fontawesome_map_test.php | 2 +- lib/tests/external/record_userfeedback_action_test.php | 2 +- lib/tests/oauth2_test.php | 1 + lib/tests/output/icon_system_test.php | 2 +- lib/tests/output/mustache_clean_string_helper_test.php | 2 +- 17 files changed, 21 insertions(+), 20 deletions(-) rename lib/phpunit/tests/{phpunit_dataset.test.php => phpunit_dataset_test.php} (99%) rename lib/tests/{core_media_player_native.php => core_media_player_native_test.php} (99%) diff --git a/backup/util/dbops/tests/restore_dbops_test.php b/backup/util/dbops/tests/restore_dbops_test.php index 59c127be41c..78060ae1ea7 100644 --- a/backup/util/dbops/tests/restore_dbops_test.php +++ b/backup/util/dbops/tests/restore_dbops_test.php @@ -301,7 +301,7 @@ class restore_dbops_testcase extends advanced_testcase { * Test restore precheck_user method * * @dataProvider precheck_user_provider - * @covers restore_dbops::precheck_user() + * @covers \restore_dbops::precheck_user() * * @param array $dbuser * @param array $backupuser diff --git a/badges/tests/badgeslib_test.php b/badges/tests/badgeslib_test.php index 2be62c01178..8becec48113 100644 --- a/badges/tests/badgeslib_test.php +++ b/badges/tests/badgeslib_test.php @@ -626,7 +626,7 @@ class badgeslib_test extends advanced_testcase { /** * Test badges observer when cohort_member_added event is fired and user required to belong to any cohort. * - * @covers award_criteria_cohort + * @covers \award_criteria_cohort */ public function test_badges_observer_any_cohort_criteria_review() { global $CFG; @@ -669,7 +669,7 @@ class badgeslib_test extends advanced_testcase { /** * Test badges observer when cohort_member_added event is fired and user required to belong to multiple (all) cohorts. * - * @covers award_criteria_cohort + * @covers \award_criteria_cohort */ public function test_badges_observer_all_cohort_criteria_review() { global $CFG; diff --git a/contentbank/tests/external/rename_content_test.php b/contentbank/tests/external/rename_content_test.php index 56a0cef380b..6f7f6ff56a6 100644 --- a/contentbank/tests/external/rename_content_test.php +++ b/contentbank/tests/external/rename_content_test.php @@ -41,7 +41,7 @@ use external_api; * @package core_contentbank * @copyright 2020 Sara Arjona * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass \core_contentbank\external + * @coversDefaultClass \core_contentbank\external\rename_content */ class rename_content_test extends \externallib_advanced_testcase { diff --git a/enrol/fee/tests/payment/service_provider_test.php b/enrol/fee/tests/payment/service_provider_test.php index 2bfe3c69070..a59af4884e4 100644 --- a/enrol/fee/tests/payment/service_provider_test.php +++ b/enrol/fee/tests/payment/service_provider_test.php @@ -28,7 +28,7 @@ namespace enrol_fee\payment; /** * Unit tests for the enrol_fee's payment subsystem callback implementation. * - * @coversDefaultClass service_provider + * @coversDefaultClass \enrol_fee\payment\service_provider */ class service_provider_test extends \advanced_testcase { diff --git a/lib/filestorage/tests/file_storage_test.php b/lib/filestorage/tests/file_storage_test.php index a74aa383103..35e7ed7af0c 100644 --- a/lib/filestorage/tests/file_storage_test.php +++ b/lib/filestorage/tests/file_storage_test.php @@ -35,7 +35,7 @@ require_once($CFG->libdir . '/filestorage/stored_file.php'); * * @copyright 2012 David Mudrak * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass file_storage + * @coversDefaultClass \file_storage */ class core_files_file_storage_testcase extends advanced_testcase { @@ -287,7 +287,7 @@ class core_files_file_storage_testcase extends advanced_testcase { * Make sure renaming is working * * @copyright 2012 Dongsheng Cai {@link http://dongsheng.org} - * @covers stored_file::rename + * @covers \stored_file::rename */ public function test_file_renaming() { global $CFG; @@ -1842,7 +1842,7 @@ class core_files_file_storage_testcase extends advanced_testcase { /** * Calling stored_file::delete_reference() on a non-reference file throws coding_exception * - * @covers stored_file::delete_reference + * @covers \stored_file::delete_reference */ public function test_delete_reference_on_nonreference() { @@ -1870,7 +1870,7 @@ class core_files_file_storage_testcase extends advanced_testcase { * Calling stored_file::delete_reference() on a reference file does not affect other * symlinks to the same original * - * @covers stored_file::delete_reference + * @covers \stored_file::delete_reference */ public function test_delete_reference_one_symlink_does_not_rule_them_all() { diff --git a/lib/filestorage/tests/file_system_filedir_test.php b/lib/filestorage/tests/file_system_filedir_test.php index 63918c38b81..f65378f460b 100644 --- a/lib/filestorage/tests/file_system_filedir_test.php +++ b/lib/filestorage/tests/file_system_filedir_test.php @@ -36,7 +36,7 @@ require_once($CFG->libdir . '/filestorage/file_system_filedir.php'); * @category files * @copyright 2017 Andrew Nicols * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass file_system_filedir + * @coversDefaultClass \file_system_filedir */ class core_files_file_system_filedir_testcase extends advanced_testcase { diff --git a/lib/filestorage/tests/file_system_test.php b/lib/filestorage/tests/file_system_test.php index 47159a78c90..1ab6acc4e65 100644 --- a/lib/filestorage/tests/file_system_test.php +++ b/lib/filestorage/tests/file_system_test.php @@ -35,7 +35,7 @@ require_once($CFG->libdir . '/filestorage/file_system.php'); * @category phpunit * @copyright 2017 Andrew Nicols * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass file_system + * @coversDefaultClass \file_system */ class core_files_file_system_testcase extends advanced_testcase { diff --git a/lib/phpunit/tests/phpunit_dataset.test.php b/lib/phpunit/tests/phpunit_dataset_test.php similarity index 99% rename from lib/phpunit/tests/phpunit_dataset.test.php rename to lib/phpunit/tests/phpunit_dataset_test.php index fcb1c5619da..f412fc65819 100644 --- a/lib/phpunit/tests/phpunit_dataset.test.php +++ b/lib/phpunit/tests/phpunit_dataset_test.php @@ -30,7 +30,7 @@ use org\bovigo\vfs\vfsStream; /** * Test phpunit_dataset features. * - * @coversDefaultClass phpunit_dataset + * @coversDefaultClass \phpunit_dataset */ class core_phpunit_dataset_testcase extends advanced_testcase { diff --git a/lib/tests/content/export/exportable_items/exportable_filearea_test.php b/lib/tests/content/export/exportable_items/exportable_filearea_test.php index bae10175ab1..7e465ddfa4e 100644 --- a/lib/tests/content/export/exportable_items/exportable_filearea_test.php +++ b/lib/tests/content/export/exportable_items/exportable_filearea_test.php @@ -38,7 +38,7 @@ use stdClass; /** * Unit tests for the `exportable_filearea` export item class. * - * @coversDefaultClass core\content\exportable_items\exportable_filearea + * @coversDefaultClass \core\content\exportable_items\exportable_filearea */ class exportable_filearea_test extends advanced_testcase { diff --git a/lib/tests/content/export/exportable_items/exportable_stored_file_test.php b/lib/tests/content/export/exportable_items/exportable_stored_file_test.php index a3fbb22fa41..61c760687c2 100644 --- a/lib/tests/content/export/exportable_items/exportable_stored_file_test.php +++ b/lib/tests/content/export/exportable_items/exportable_stored_file_test.php @@ -37,7 +37,7 @@ use stored_file; /** * Unit tests for the `exportable_stored_file` export item class. * - * @coversDefaultClass core\content\exportable_items\exportable_stored_file + * @coversDefaultClass \core\content\exportable_items\exportable_stored_file */ class exportable_stored_file_test extends advanced_testcase { diff --git a/lib/tests/content/export/exportable_items/exportable_textarea_test.php b/lib/tests/content/export/exportable_items/exportable_textarea_test.php index e42f0ca5952..5e11c3d2afe 100644 --- a/lib/tests/content/export/exportable_items/exportable_textarea_test.php +++ b/lib/tests/content/export/exportable_items/exportable_textarea_test.php @@ -38,7 +38,7 @@ use stdClass; /** * Unit tests for the `exportable_textarea` export item class. * - * @coversDefaultClass core\content\exportable_items\exportable_textarea + * @coversDefaultClass \core\content\exportable_items\exportable_textarea */ class exportable_textarea_test extends advanced_testcase { diff --git a/lib/tests/core_media_player_native.php b/lib/tests/core_media_player_native_test.php similarity index 99% rename from lib/tests/core_media_player_native.php rename to lib/tests/core_media_player_native_test.php index 362a0cd0a72..dc406410388 100644 --- a/lib/tests/core_media_player_native.php +++ b/lib/tests/core_media_player_native_test.php @@ -31,7 +31,7 @@ require_once(__DIR__ . '/fixtures/testable_core_media_player_native.php'); * * @package core * @category test - * @covers core_media_player_native + * @covers \core_media_player_native * @copyright 2019 Ruslan Kabalin * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ diff --git a/lib/tests/external/output/icon_system/load_fontawesome_map_test.php b/lib/tests/external/output/icon_system/load_fontawesome_map_test.php index 5f94b7ac191..5e970a42f4b 100644 --- a/lib/tests/external/output/icon_system/load_fontawesome_map_test.php +++ b/lib/tests/external/output/icon_system/load_fontawesome_map_test.php @@ -38,7 +38,7 @@ require_once($CFG->dirroot . '/webservice/tests/helpers.php'); * * @copyright 2020 Andrew Nicols * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass core\external\output\icon_system\load_fontawesome_map + * @coversDefaultClass \core\external\output\icon_system\load_fontawesome_map */ class load_fontawesome_map_test extends externallib_advanced_testcase { diff --git a/lib/tests/external/record_userfeedback_action_test.php b/lib/tests/external/record_userfeedback_action_test.php index 4a4507f1f21..fa99bebe79d 100644 --- a/lib/tests/external/record_userfeedback_action_test.php +++ b/lib/tests/external/record_userfeedback_action_test.php @@ -39,7 +39,7 @@ require_once($CFG->dirroot . '/webservice/tests/helpers.php'); * * @copyright 2020 Shamim Rezaie * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass record_userfeedback_action + * @coversDefaultClass \core\external\record_userfeedback_action */ class record_userfeedback_action_test extends externallib_advanced_testcase { diff --git a/lib/tests/oauth2_test.php b/lib/tests/oauth2_test.php index 4da5d1e56b0..c2b206a40a5 100644 --- a/lib/tests/oauth2_test.php +++ b/lib/tests/oauth2_test.php @@ -30,6 +30,7 @@ defined('MOODLE_INTERNAL') || die(); * @package core * @copyright 2017 Damyon Wiese * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later. + * @coversDefaultClass \core\oauth2\api */ class core_oauth2_testcase extends advanced_testcase { diff --git a/lib/tests/output/icon_system_test.php b/lib/tests/output/icon_system_test.php index d018ed6b1c7..6d83c67e725 100644 --- a/lib/tests/output/icon_system_test.php +++ b/lib/tests/output/icon_system_test.php @@ -31,7 +31,7 @@ use coding_exception; /** * Unit tests for the `icon_system` class. * - * @coversDefaultClass core\output\icon_system + * @coversDefaultClass \core\output\icon_system */ class icon_system_test extends advanced_testcase { /** diff --git a/lib/tests/output/mustache_clean_string_helper_test.php b/lib/tests/output/mustache_clean_string_helper_test.php index a8eedb83214..73d74fe21b8 100644 --- a/lib/tests/output/mustache_clean_string_helper_test.php +++ b/lib/tests/output/mustache_clean_string_helper_test.php @@ -25,7 +25,7 @@ namespace core\output; * @category test * @copyright 2021 Shamim Rezaie * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - * @coversDefaultClass mustache_clean_string_helper + * @coversDefaultClass \core\output\mustache_clean_string_helper */ class mustache_clean_string_helper_test extends \basic_testcase {