From f5661d4525f6199a0679e95c5833591dc1ca8bbf Mon Sep 17 00:00:00 2001
From: tjhunt <tjhunt>
Date: Thu, 27 Nov 2008 04:11:45 +0000
Subject: [PATCH] quiz overview report: MDL-17235 SQL error was breaking 'Show
 all students' in quizzes with feedback.

Thanks to Juan Leyva for finding the problem and suggesting the fix.
---
 mod/quiz/report/overview/report.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
index fe2420fe605..31c69b67e77 100644
--- a/mod/quiz/report/overview/report.php
+++ b/mod/quiz/report/overview/report.php
@@ -407,7 +407,7 @@ class quiz_report extends quiz_default_report {
         if ($hasfeedback) {
             $factor = $quiz->grade/$quiz->sumgrades;
             $select .= ', qf.feedbacktext ';
-            $from .= " JOIN {$CFG->prefix}quiz_feedback AS qf ON " .
+            $from .= " LEFT JOIN {$CFG->prefix}quiz_feedback AS qf ON " .
                     "qf.quizid = $quiz->id AND qf.mingrade <= qa.sumgrades * $factor AND qa.sumgrades * $factor < qf.maxgrade";
         }
 
@@ -488,6 +488,9 @@ class quiz_report extends quiz_default_report {
                     }
                     if ($hasfeedback) {
                         if ($attempt->timefinish) {
+                            if (empty($attempt->feedbacktext)) {
+                                $attempt->feedbacktext = '';
+                            }
                             $row[] = format_text($attempt->feedbacktext, FORMAT_MOODLE, $nocleanformatoptions);
                         } else {
                             $row[] = '-';