diff --git a/lib/classes/shutdown_manager.php b/lib/classes/shutdown_manager.php index 101b4a1417b..ffd0da99485 100644 --- a/lib/classes/shutdown_manager.php +++ b/lib/classes/shutdown_manager.php @@ -144,7 +144,7 @@ class core_shutdown_manager { error_log('Invalid custom shutdown function detected '.var_export($callback, true)); // @codingStandardsIgnoreEnd } - self::$callbacks[] = [$callback, $params ?? []]; + self::$callbacks[] = [$callback, $params ? array_values($params) : []]; } /** diff --git a/lib/ddl/sql_generator.php b/lib/ddl/sql_generator.php index 99fd21f1390..6215eb1e2c0 100644 --- a/lib/ddl/sql_generator.php +++ b/lib/ddl/sql_generator.php @@ -1237,7 +1237,7 @@ abstract class sql_generator { } // Now call the standard $DB->sql_concat() DML function - return call_user_func_array(array($this->mdb, 'sql_concat'), $elements); + return call_user_func_array(array($this->mdb, 'sql_concat'), array_values($elements)); } /** diff --git a/lib/dml/sqlsrv_native_moodle_database.php b/lib/dml/sqlsrv_native_moodle_database.php index 799438b6591..a359c8999e8 100644 --- a/lib/dml/sqlsrv_native_moodle_database.php +++ b/lib/dml/sqlsrv_native_moodle_database.php @@ -1426,7 +1426,7 @@ class sqlsrv_native_moodle_database extends moodle_database { for ($n = count($elements) - 1; $n > 0; $n--) { array_splice($elements, $n, 0, $separator); } - return call_user_func_array(array($this, 'sql_concat'), $elements); + return call_user_func_array(array($this, 'sql_concat'), array_values($elements)); } public function sql_isempty($tablename, $fieldname, $nullablefield, $textfield) { diff --git a/lib/moodlelib.php b/lib/moodlelib.php index e9947ad1bad..75ac71f4bde 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -8062,6 +8062,16 @@ function component_callback($component, $function, array $params = array(), $def $functionname = component_callback_exists($component, $function); + if ($params && (array_keys($params) !== range(0, count($params) - 1))) { + // PHP 8 allows to have associative arrays in the call_user_func_array() parameters but + // PHP 7 does not. Using associative arrays can result in different behavior in different PHP versions. + // See https://php.watch/versions/8.0/named-parameters#named-params-call_user_func_array + // This check can be removed when minimum PHP version for Moodle is raised to 8. + debugging('Parameters array can not be an associative array while Moodle supports both PHP 7 and PHP 8.', + DEBUG_DEVELOPER); + $params = array_values($params); + } + if ($functionname) { // Function exists, so just return function result. $ret = call_user_func_array($functionname, $params);