From f4c8daa479a6a46adc1d4e8979bf4d59a79865d1 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Tue, 19 Oct 2021 14:20:15 +0100
Subject: [PATCH] MDL-72850 search: show role alias in "Teacher roles"
 configuration.

---
 admin/settings/plugins.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/admin/settings/plugins.php b/admin/settings/plugins.php
index dbe15ee3f48..498ae168000 100644
--- a/admin/settings/plugins.php
+++ b/admin/settings/plugins.php
@@ -651,8 +651,8 @@ if ($hassiteconfig) {
         3, $options));
     // Teacher roles.
     $options = [];
-    foreach (get_all_roles() as $role) {
-        $options[$role->id] = $role->shortname;
+    foreach (role_get_names() as $role) {
+        $options[$role->id] = $role->localname;
     }
     $temp->add(new admin_setting_configmultiselect('searchteacherroles',
         new lang_string('searchteacherroles', 'admin'),