diff --git a/lib/grade/grade_category.php b/lib/grade/grade_category.php index f26f8212d01..e89b7ea5b72 100644 --- a/lib/grade/grade_category.php +++ b/lib/grade/grade_category.php @@ -2249,14 +2249,11 @@ class grade_category extends grade_object { } //if marking category visible make sure parent category is visible MDL-21367 - if( !$hidden ) { + if ($this->is_hidden() != $hidden) { $category_array = grade_category::fetch_all(array('id'=>$this->parent)); if ($category_array && array_key_exists($this->parent, $category_array)) { $category = $category_array[$this->parent]; - //call set_hidden on the category regardless of whether it is hidden as its parent might be hidden - //if($category->is_hidden()) { - $category->set_hidden($hidden, false); - //} + $category->set_hidden($hidden, false); } } } diff --git a/lib/grade/grade_item.php b/lib/grade/grade_item.php index 6fc05cfe434..d29761bd89d 100644 --- a/lib/grade/grade_item.php +++ b/lib/grade/grade_item.php @@ -608,14 +608,11 @@ class grade_item extends grade_object { } //if marking item visible make sure category is visible MDL-21367 - if( !$hidden ) { + if ($this->is_hidden() != $hidden) { $category_array = grade_category::fetch_all(array('id'=>$this->categoryid)); if ($category_array && array_key_exists($this->categoryid, $category_array)) { $category = $category_array[$this->categoryid]; - //call set_hidden on the category regardless of whether it is hidden as its parent might be hidden - //if($category->is_hidden()) { - $category->set_hidden($hidden, false); - //} + $category->set_hidden($hidden, false); } } }