From f32c2fd781dbf0ec19bd0d8d7e993ad33fe447fc Mon Sep 17 00:00:00 2001 From: Rajesh Taneja Date: Thu, 6 Oct 2016 15:03:56 +0800 Subject: [PATCH] MDL-55986 behat: use double quotes not single On windows we need option value to be in double quotes, else it fails --- admin/tool/behat/cli/init.php | 2 +- admin/tool/behat/cli/util.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/tool/behat/cli/init.php b/admin/tool/behat/cli/init.php index fd728ef8336..48327c7814d 100644 --- a/admin/tool/behat/cli/init.php +++ b/admin/tool/behat/cli/init.php @@ -94,7 +94,7 @@ if ($options['parallel'] && $options['parallel'] > 1) { // Sanitize all input options, so they can be passed to util. foreach ($options as $option => $value) { if ($value) { - $commandoptions .= " --$option='$value'"; + $commandoptions .= " --$option=\"$value\""; } } } else { diff --git a/admin/tool/behat/cli/util.php b/admin/tool/behat/cli/util.php index e82e7fb3e22..a601967ae2e 100644 --- a/admin/tool/behat/cli/util.php +++ b/admin/tool/behat/cli/util.php @@ -269,7 +269,7 @@ function commands_to_execute($options) { if ($options[$option]) { $extra .= " --$option"; if ($value) { - $extra .= "='$value'"; + $extra .= "=\"$value\""; } } }