From 7fedd96eda38f7d8f5851ecd477d7ddc6d7402c1 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Wed, 4 Mar 2026 14:00:38 +0800 Subject: [PATCH 1/2] MDL-87810 question: Fix colour contrast issues on question view * Lighten the background for the question formulation container. * Lighten the background for the question feedback container while slightly darkening the text font as well. --- public/theme/boost/scss/moodle/question.scss | 6 +++--- public/theme/boost/style/moodle.css | 6 +++--- public/theme/classic/style/moodle.css | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/public/theme/boost/scss/moodle/question.scss b/public/theme/boost/scss/moodle/question.scss index a3b47c76d0f..aa8badee91f 100644 --- a/public/theme/boost/scss/moodle/question.scss +++ b/public/theme/boost/scss/moodle/question.scss @@ -346,9 +346,9 @@ body.path-question-type { } .que .outcome, .que .comment { - color: shift-color($warning, $alert-color-scale - 9%); + color: shift-color($warning, $alert-color-scale); border-color: shift-color($warning, $alert-border-scale); - @include gradient-bg(shift-color($warning, $alert-bg-scale)); + @include gradient-bg(shift-color($warning, $alert-bg-scale - 5%)); // Darken link colour inside comments for better colour contrast against regular text. a { color: darken($link-color, 30%); @@ -358,7 +358,7 @@ body.path-question-type { .que .formulation { color: shift-color($info, $alert-color-scale + 40%); border-color: shift-color($info, $alert-border-scale); - @include gradient-bg(shift-color($info, $alert-bg-scale)); + @include gradient-bg(shift-color($info, $alert-bg-scale - 10%)); } .que.multichoice .answer div.r0 .icon.fa-check, diff --git a/public/theme/boost/style/moodle.css b/public/theme/boost/style/moodle.css index 27b9bc15600..fe4782c1287 100644 --- a/public/theme/boost/style/moodle.css +++ b/public/theme/boost/style/moodle.css @@ -34178,9 +34178,9 @@ body.path-question-type .fitem .col-form-label.visually-hidden:not(legend):not([ .que .outcome, .que .comment { - color: #a67736; + color: #90682f; border-color: #fbe6ca; - background-color: #fcefdc; + background-color: #fdf3e4; } .que .outcome a, .que .comment a { @@ -34190,7 +34190,7 @@ body.path-question-type .fitem .col-form-label.visually-hidden:not(legend):not([ .que .formulation { color: #001a1e; border-color: #b3d9e0; - background-color: #cce6ea; + background-color: #e6f2f5; } .que.multichoice .answer div.r0 .icon.fa-check, diff --git a/public/theme/classic/style/moodle.css b/public/theme/classic/style/moodle.css index 9ec7157fd60..1dff816f4dd 100644 --- a/public/theme/classic/style/moodle.css +++ b/public/theme/classic/style/moodle.css @@ -34178,9 +34178,9 @@ body.path-question-type .fitem .col-form-label.visually-hidden:not(legend):not([ .que .outcome, .que .comment { - color: #a67736; + color: #90682f; border-color: #fbe6ca; - background-color: #fcefdc; + background-color: #fdf3e4; } .que .outcome a, .que .comment a { @@ -34190,7 +34190,7 @@ body.path-question-type .fitem .col-form-label.visually-hidden:not(legend):not([ .que .formulation { color: #001a1e; border-color: #b3d9e0; - background-color: #cce6ea; + background-color: #e6f2f5; } .que.multichoice .answer div.r0 .icon.fa-check, From dd682468f109823d01a73460531417d92dbad67b Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Wed, 4 Mar 2026 18:51:56 +0800 Subject: [PATCH 2/2] MDL-87810 quiz: Accessibility Behat coverage for quiz attempt --- public/mod/quiz/tests/behat/quiz_feedback.feature | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/public/mod/quiz/tests/behat/quiz_feedback.feature b/public/mod/quiz/tests/behat/quiz_feedback.feature index d8738d88b05..5b01bc15220 100644 --- a/public/mod/quiz/tests/behat/quiz_feedback.feature +++ b/public/mod/quiz/tests/behat/quiz_feedback.feature @@ -22,10 +22,10 @@ Feature: Enable deferred or immediate feedback for quiz | contextlevel | reference | name | | Activity module | qbank1 | Test questions | And the following "questions" exist: - | questioncategory | qtype | name | questiontext | - | Test questions | truefalse | TF1 | First question | + | questioncategory | qtype | name | questiontext | generalfeedback | + | Test questions | truefalse | TF1 | Moodle is the best LMS | You should know that Moodle is the best LMS | - @javascript + @javascript @accessibility Scenario: Attempt quiz with How questions behave set to Deferred Feedback Given the following "activity" exists: | activity | quiz | @@ -48,16 +48,18 @@ Feature: Enable deferred or immediate feedback for quiz # Confirm that check button does not exist when attempting quiz Then "Check Question 1" "button" should not exist And I set the field "False" to "1" + And the "region-main" "region" should meet accessibility standards And I press "Finish attempt ..." And I should not see "This is the wrong answer." - And I should not see "You should have selected true." + And I should not see "You should know that Moodle is the best LMS" And I should not see "The correct answer is 'True'." And I press "Submit all and finish" # Confirm that quiz answer feedback only appears when attempt is submitted And I click on "Submit all and finish" "button" in the "Submit all your answers and finish?" "dialogue" And I should see "This is the wrong answer." - And I should see "You should have selected true." + And I should see "You should know that Moodle is the best LMS" And I should see "The correct answer is 'True'." + And the "region-main" "region" should meet accessibility standards Scenario: Attempt quiz with How questions behave set to Immediate Feedback Given the following "activity" exists: @@ -101,7 +103,7 @@ Feature: Enable deferred or immediate feedback for quiz | 1 | True | When I am on the "Quiz 1" "quiz activity" page logged in as student1 And I click on "Review" "link" - Then I should see "You should have selected true." + Then I should see "You should know that Moodle is the best LMS" And I see "This is the right answer." And I see "The correct answer is 'True'." And the following exist in the "quizreviewsummary" table: