From 166c43d86c64f55c97a66284387861088811a66e Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Tue, 13 Nov 2018 17:11:17 +0000 Subject: [PATCH] MDL-61990 outputrequirementslib: improve debug message --- lib/outputrequirementslib.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/outputrequirementslib.php b/lib/outputrequirementslib.php index ded44aad26c..28d3c709faa 100644 --- a/lib/outputrequirementslib.php +++ b/lib/outputrequirementslib.php @@ -1023,7 +1023,9 @@ class page_requirements_manager { if ($CFG->debugdeveloper) { $toomanyparamslimit = 1024; if (strlen($strparams) > $toomanyparamslimit) { - debugging('Too many params passed to js_call_amd("' . $fullmodule . '", "' . $func . '")', DEBUG_DEVELOPER); + debugging('Too much data passed as arguments to js_call_amd("' . $fullmodule . '", "' . $func . + '"). Generally there are better ways to pass lots of data from PHP to JavaScript, for example via Ajax, data attributes, ... . ' . + 'This warning is triggered if the argument string becomes longer than ' . $toomanyparamslimit . ' characters.', DEBUG_DEVELOPER); } }