From f1a9fcd96a2f48a1daa73107a480ca06db6be492 Mon Sep 17 00:00:00 2001
From: Frederic Massart <fred@moodle.com>
Date: Fri, 22 Apr 2016 17:03:50 +0800
Subject: [PATCH] MDL-53924 competency: Relax strictness of default
 capabilities

---
 admin/tool/lpmigrate/db/access.php |  1 -
 lib/db/access.php                  | 36 +++++++++++++-----------------
 2 files changed, 15 insertions(+), 22 deletions(-)

diff --git a/admin/tool/lpmigrate/db/access.php b/admin/tool/lpmigrate/db/access.php
index f81d2249d8b..d9658aada22 100644
--- a/admin/tool/lpmigrate/db/access.php
+++ b/admin/tool/lpmigrate/db/access.php
@@ -31,6 +31,5 @@ $capabilities = array(
         'archetypes' => array(
             'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
 );
diff --git a/lib/db/access.php b/lib/db/access.php
index a5692a7847a..9136516abac 100644
--- a/lib/db/access.php
+++ b/lib/db/access.php
@@ -2072,7 +2072,6 @@ $capabilities = array(
         'archetypes' => array(
             'user' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/block:view'
     ),
     'moodle/competency:competencygrade' => array(
         'captype' => 'write',
@@ -2091,7 +2090,6 @@ $capabilities = array(
             'editingteacher' => CAP_ALLOW,
             'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:backup'
     ),
     'moodle/competency:coursecompetencyconfigure' => array(
         'captype' => 'write',
@@ -2099,7 +2097,6 @@ $capabilities = array(
         'archetypes' => array(
             'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:backup'
     ),
     'moodle/competency:coursecompetencygradable' => array(
         'captype' => 'read',
@@ -2115,7 +2112,6 @@ $capabilities = array(
         'archetypes' => array(
             'user' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/block:view'
     ),
     // Evidence.
     'moodle/competency:evidencedelete' => array(
@@ -2130,43 +2126,41 @@ $capabilities = array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planmanagedraft' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planmanageown' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planmanageowndraft' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planview' => array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planviewdraft' => array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planviewown' => array(
         'captype' => 'read',
@@ -2174,19 +2168,18 @@ $capabilities = array(
         'archetypes' => array(
             'user' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/block:view'
     ),
     'moodle/competency:planviewowndraft' => array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:planrequestreview' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         )
     ),
     'moodle/competency:planrequestreviewown' => array(
@@ -2200,15 +2193,15 @@ $capabilities = array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:plancomment' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:plancommentown' => array(
         'captype' => 'write',
@@ -2222,6 +2215,7 @@ $capabilities = array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_USER,     // And CONTEXT_COURSE.
         'archetypes' => array(
+            'manager' => CAP_ALLOW,
             'editingteacher' => CAP_ALLOW,
             'teacher' => CAP_ALLOW
         )
@@ -2230,6 +2224,7 @@ $capabilities = array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         )
     ),
     'moodle/competency:usercompetencyrequestreviewown' => array(
@@ -2243,15 +2238,15 @@ $capabilities = array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:usercompetencycomment' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:usercompetencycommentown' => array(
         'captype' => 'write',
@@ -2265,23 +2260,23 @@ $capabilities = array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_COURSECAT,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:templateview' => array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_COURSECAT,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     // User evidence.
     'moodle/competency:userevidencemanage' => array(
         'captype' => 'write',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
     'moodle/competency:userevidencemanageown' => array(
         'captype' => 'write',
@@ -2289,14 +2284,13 @@ $capabilities = array(
         'archetypes' => array(
             'user' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/block:view'
     ),
     'moodle/competency:userevidenceview' => array(
         'captype' => 'read',
         'contextlevel' => CONTEXT_USER,
         'archetypes' => array(
+            'manager' => CAP_ALLOW
         ),
-        'clonepermissionsfrom' => 'moodle/site:config'
     ),
 
 );