MDL-76109 core: Don't check password policy for guest user

Besides adding the is_guest() check in the check_password_policy() condition, I also changed the temporary user ID because the temporary user and the guest must not share the same ID. Otherwise, it will raise an error. Co-authored-by: Andrei Bautu <[email protected]>
2023-11-30 10:35:28 +07:00
parent b1bb5671df
commit f16b42d013
2 changed files with 4 additions and 2 deletions
@@ -1113,7 +1113,9 @@ function signup_validate_data($data, $files) {

    // Construct fake user object to check password policy against required information.
    $tempuser = new stdClass();
-    $tempuser->id = 1;
+    // To prevent errors with check_password_policy(),
+    // the temporary user and the guest must not share the same ID.
+    $tempuser->id = (int)$CFG->siteguest + 1;
    $tempuser->username = $data['username'];
    $tempuser->firstname = $data['firstname'];
    $tempuser->lastname = $data['lastname'];