L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-62680 output: Only hide icons with no label

Browse Source 
For accessibility we don't want to read an icon with a label immediately next to the label,
but in this case it's clearer for the icon to have no alt text / title for both
screen readers and non-screen readers. Worse is not reading important information just
because it's displayed as an icon.
This commit is contained in:
Damyon Wiese
2019-02-07 10:08:19 +08:00
parent 4c5b60a0f9
commit ef96eb02fb
6 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/outputcomponents_test.php
+29
View File
@@ -436,4 +436,33 @@ EOF;
$this->assertEquals($expecteda, $pbara->pagelinks);
$this->assertEquals($expectedb, $pbarb->pagelinks);
}
public function test_pix_icon() {
$this->resetAfterTest();
$page = new moodle_page();
set_config('theme', 'boost');
// Need to reset after changing theme.
$page->reset_theme_and_output();
$renderer = $page->get_renderer('core');
$reason = 'An icon with no alt text is hidden from screenreaders.';
$this->assertContains('aria-hidden="true"', $renderer->pix_icon('t/print', ''), $reason);
$reason = 'An icon with alt text is not hidden from screenreaders.';
$this->assertNotContains('aria-hidden="true"', $renderer->pix_icon('t/print', 'Print'), $reason);
// Test another theme with a different icon system.
set_config('theme', 'clean');
// Need to reset after changing theme.
$page->reset_theme_and_output();
$renderer = $page->get_renderer('core');
$reason = 'An icon with no alt text is hidden from screenreaders.';
$this->assertContains('aria-hidden="true"', $renderer->pix_icon('t/print', ''), $reason);
$reason = 'An icon with alt text is not hidden from screenreaders.';
$this->assertNotContains('aria-hidden="true"', $renderer->pix_icon('t/print', 'Print'), $reason);
}
}