From ef780a0051e9d0f4e7374cd8c27a95a890bbb96d Mon Sep 17 00:00:00 2001
From: Martin Gauk <gauk@math.tu-berlin.de>
Date: Tue, 20 Mar 2018 13:13:08 +0000
Subject: [PATCH] MDL-61519 coursecat: do not cache get_all_children_ids

---
 lib/coursecatlib.php | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/lib/coursecatlib.php b/lib/coursecatlib.php
index b5fcff4306b..81c3b88d12e 100644
--- a/lib/coursecatlib.php
+++ b/lib/coursecatlib.php
@@ -1178,20 +1178,15 @@ class coursecat implements renderable, cacheable_object, IteratorAggregate {
      * @return int[]
      */
     public function get_all_children_ids() {
-        $coursecattreecache = cache::make('core', 'coursecattree');
-        $children = $coursecattreecache->get($this->id . 'allchildren');
-        if ($children === false) {
-            $children = [];
-            $walk = [$this->id];
-            while (count($walk) > 0) {
-                $catid = array_pop($walk);
-                $directchildren = self::get_tree($catid);
-                if ($directchildren !== false && count($directchildren) > 0) {
-                    $walk = array_merge($walk, $directchildren);
-                    $children = array_merge($children, $directchildren);
-                }
+        $children = [];
+        $walk = [$this->id];
+        while (count($walk) > 0) {
+            $catid = array_pop($walk);
+            $directchildren = self::get_tree($catid);
+            if ($directchildren !== false && count($directchildren) > 0) {
+                $walk = array_merge($walk, $directchildren);
+                $children = array_merge($children, $directchildren);
             }
-            $coursecattreecache->set($this->id . 'allchildren', $children);
         }
 
         return $children;