From eec4ca8cf0c01320348ab231d8301029adc8e2ac Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Wed, 21 Feb 2024 08:08:43 +0100 Subject: [PATCH] NOBUG: Avoid already closed PRs to get any comment This is an adjustment for MDL-77166, where the auto-close PRs workflow was introduced. That workflow does close and lock any PR in the moodle/moodle.git repo. We have detected that, when proceeding to lock the PRs it's always adding a comment. But we only want that when closing the PRs (as they are open). When the only task is to lock them (normally old PRs that are already closed by not locked) we don't want any comment to be added (so no notification/spam happens on those old PRs). Luckily there is a setting for it: skip-closed-pr-comment: true So applying for it. Note that we have run various tests in fork repository and it seems to be working ok. Only open PRs got the comment and closed PRs were silently locked. --- .github/workflows/close-pull-requests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/close-pull-requests.yml b/.github/workflows/close-pull-requests.yml index eb439f8380a..839af0b0242 100644 --- a/.github/workflows/close-pull-requests.yml +++ b/.github/workflows/close-pull-requests.yml @@ -16,6 +16,7 @@ jobs: with: process-only: prs close-pr: true + skip-closed-pr-comment: true pr-comment: > **Please, don't open pull requests via GitHub.**