From ee8a4fbb95241b9458550f33376ee287ad97c49b Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Fri, 5 Jun 2020 16:19:02 +0800 Subject: [PATCH] MDL-68933 core: Use get_config() to fetch theme version number Fetching the theme version number via get_component_version() which requires lib/adminlib.php unnecessarily increases memory consumption. Using get_config() is more direct and simpler. --- lib/classes/userfeedback.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/classes/userfeedback.php b/lib/classes/userfeedback.php index 99be75a624f..d74f6214984 100644 --- a/lib/classes/userfeedback.php +++ b/lib/classes/userfeedback.php @@ -124,14 +124,13 @@ class core_userfeedback { */ public static function make_link(): moodle_url { global $CFG, $PAGE; - require_once($CFG->libdir . '/adminlib.php'); $baseurl = $CFG->userfeedback_url ?? 'https://feedback.moodle.org/lms'; $lang = clean_param(current_language(), PARAM_LANG); // Avoid breaking WS because of incorrect package langs. $moodleurl = $CFG->wwwroot; $moodleversion = $CFG->release; $theme = $PAGE->theme->name; - $themeversion = get_component_version('theme_' . $theme); + $themeversion = get_config('theme_'.$theme, 'version'); $url = new moodle_url($baseurl, [ 'lang' => $lang,