From 40ad488405b003437ee2823cf268608b6549746a Mon Sep 17 00:00:00 2001
From: Peter Dias <peter@moodle.com>
Date: Thu, 14 Apr 2022 12:25:15 +0800
Subject: [PATCH] MDL-74407 navigation: Perform a strict array_search for node
 keys

Perform strict array_search due to conflicting results in versions <php8.0
---
 lib/classes/navigation/views/secondary.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/classes/navigation/views/secondary.php b/lib/classes/navigation/views/secondary.php
index 385c5d6755d..13ecdce8aec 100644
--- a/lib/classes/navigation/views/secondary.php
+++ b/lib/classes/navigation/views/secondary.php
@@ -417,7 +417,7 @@ class secondary extends view {
 
         if ($courseadminnode) {
             foreach ($courseadminnode->children as $other) {
-                if (array_search($other->key, $expectedcourseadmin) === false) {
+                if (array_search($other->key, $expectedcourseadmin, true) === false) {
                     $othernode = $this->get_first_action_for_node($other);
                     $recursivenode = $othernode && !$rootnode->get($othernode->key) ? $othernode : $other;
                     // Get the first node and check whether it's been added already.