L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-76074 completion: fixed filter in reports with custom user fields

Browse Source 
When the site uses custom user text fields that would show up in a
user list, the filter for firstname or lastname didnt work anymore.
If a filter was used, no result would show up. Users where shown only
when the course reports where used without filters.
This commit is contained in:
Stephan Robotta
2022-12-02 09:42:35 +01:00
parent 1d863c338a
commit ecc6b31176
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/completionlib.php
+3 -2
View File
@@ -1424,14 +1424,15 @@ class completion_info {
$fieldssql = $userfieldsapi->get_sql('u', true);
$sql = 'SELECT u.id, u.idnumber ' . $fieldssql->selects;
$sql .= ' FROM (' . $enrolledsql . ') eu JOIN {user} u ON u.id = eu.id';
$sql .= $fieldssql->joins;
$params = array_merge($params, $fieldssql->params);
if ($where) {
$sql .= " AND $where";
$params = array_merge($params, $whereparams);
}
$sql .= $fieldssql->joins;
$params = array_merge($params, $fieldssql->params);
if ($sort) {
$sql .= " ORDER BY $sort";
}