From a0f9277b51305b5a8d9a94ae8d05d8a062d33dd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Mudr=C3=A1k?= Date: Wed, 19 Apr 2017 13:40:10 +0200 Subject: [PATCH] MDL-58613 workshop: Provide all data to display user name Additional fields such as middlename, alternatename and others were not passed to the fullname(), causing a debugging message. --- mod/workshop/allocation/random/lib.php | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/mod/workshop/allocation/random/lib.php b/mod/workshop/allocation/random/lib.php index f878fe72f1f..ffed33cad42 100644 --- a/mod/workshop/allocation/random/lib.php +++ b/mod/workshop/allocation/random/lib.php @@ -164,13 +164,14 @@ class workshop_random_allocator implements workshop_allocator { // by reviewer $result->log(get_string('numofdeallocatedassessment', 'workshopallocation_random', count($delassessments)), 'info'); foreach ($delassessments as $delassessmentkey => $delassessmentid) { - $a = new stdclass(); - $a->authorname = fullname((object)array( - 'lastname' => $assessments[$delassessmentid]->authorlastname, - 'firstname' => $assessments[$delassessmentid]->authorfirstname)); - $a->reviewername = fullname((object)array( - 'lastname' => $assessments[$delassessmentid]->reviewerlastname, - 'firstname' => $assessments[$delassessmentid]->reviewerfirstname)); + $author = (object) []; + $reviewer = (object) []; + username_load_fields_from_object($author, $assessments[$delassessmentid], 'author'); + username_load_fields_from_object($reviewer, $assessments[$delassessmentid], 'reviewer'); + $a = [ + 'authorname' => fullname($author), + 'reviewername' => fullname($reviewer), + ]; if (!is_null($assessments[$delassessmentid]->grade)) { $result->log(get_string('allocationdeallocategraded', 'workshopallocation_random', $a), 'error', 1); unset($delassessments[$delassessmentkey]);