From 11f8718780d769fec8c3d7fcc9a6d7b65f1b59b4 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Fri, 9 Nov 2012 15:43:22 +0800 Subject: [PATCH 1/5] MDL-36323 usability: Normalising icons used in blocks --- .../block_activity_modules.php | 4 +-- blocks/community/block_community.php | 2 +- blocks/course_list/block_course_list.php | 4 +-- blocks/dock.js | 10 ++++-- blocks/navigation/styles.css | 31 ++++++++++++------ blocks/participants/block_participants.php | 2 +- blocks/private_files/renderer.php | 4 +-- blocks/settings/styles.css | 15 ++++----- .../site_main_menu/block_site_main_menu.php | 4 +-- grade/lib.php | 4 +-- lib/enrollib.php | 4 +-- lib/navigationlib.php | 6 ++-- pix/i/export.png | Bin 0 -> 265 bytes pix/i/export.svg | 16 +++++++++ pix/i/import.png | Bin 0 -> 266 bytes pix/i/import.svg | 16 +++++++++ pix/i/rolesm.png | Bin 0 -> 233 bytes pix/i/rolesm.svg | 15 +++++++++ theme/base/style/blocks.css | 5 +-- theme/base/style/core.css | 3 +- theme/base/style/dock.css | 10 +++--- theme/upgrade.txt | 2 ++ 22 files changed, 111 insertions(+), 46 deletions(-) create mode 100644 pix/i/export.png create mode 100644 pix/i/export.svg create mode 100644 pix/i/import.png create mode 100644 pix/i/import.svg create mode 100644 pix/i/rolesm.png create mode 100644 pix/i/rolesm.svg diff --git a/blocks/activity_modules/block_activity_modules.php b/blocks/activity_modules/block_activity_modules.php index 0a391b03b78..5edaa9805d0 100644 --- a/blocks/activity_modules/block_activity_modules.php +++ b/blocks/activity_modules/block_activity_modules.php @@ -53,10 +53,10 @@ class block_activity_modules extends block_list { foreach ($modfullnames as $modname => $modfullname) { if ($modname === 'resources') { - $icon = $OUTPUT->pix_icon(file_extension_icon('.htm'), '', 'moodle', array('class' => 'icon')). ' '; + $icon = $OUTPUT->pix_icon(file_extension_icon('.htm'), '', 'moodle', array('class' => 'icon')). ''; $this->content->items[] = ''.$icon.$modfullname.''; } else { - $icon = ' '; + $icon = ''; $this->content->items[] = ''.$icon.$modfullname.''; } } diff --git a/blocks/community/block_community.php b/blocks/community/block_community.php index c211342cc18..3702f11b1b9 100644 --- a/blocks/community/block_community.php +++ b/blocks/community/block_community.php @@ -72,7 +72,7 @@ class block_community extends block_list { 'class' => 'icon', 'alt' => get_string('addcourse', 'block_community'))); $addcourseurl = new moodle_url('/blocks/community/communitycourse.php', array('add' => true, 'courseid' => $this->page->course->id)); - $searchlink = html_writer::tag('a', $icon . ' ' . get_string('addcourse', 'block_community'), + $searchlink = html_writer::tag('a', $icon . get_string('addcourse', 'block_community'), array('href' => $addcourseurl->out(false))); $this->content->items[] = $searchlink; diff --git a/blocks/course_list/block_course_list.php b/blocks/course_list/block_course_list.php index 2e6fa7c7306..540c49afc27 100644 --- a/blocks/course_list/block_course_list.php +++ b/blocks/course_list/block_course_list.php @@ -23,7 +23,7 @@ class block_course_list extends block_list { $this->content->icons = array(); $this->content->footer = ''; - $icon = ' '; + $icon = ''; $adminseesall = true; if (isset($CFG->block_course_list_adminview)) { @@ -109,7 +109,7 @@ class block_course_list extends block_list { return; } - $icon = ' '; + $icon = ''; // shortcut - the rest is only for logged in users! if (!isloggedin() || isguestuser()) { diff --git a/blocks/dock.js b/blocks/dock.js index 34a859d41b6..7aa22e34ee1 100644 --- a/blocks/dock.js +++ b/blocks/dock.js @@ -532,10 +532,16 @@ M.core_dock.fixTitleOrientation = function(item, title, text) { 'position' : 'relative', 'fontSize' : fontsize, 'width' : width, - 'top' : width/2, - 'right' : width/2 - height + 'top' : width/2 }); + // Positioning is different when in RTL mode. + if (Y.one(document.body).hasClass('dir-rtl')) { + title.setStyle('left', width/2 - height); + } else { + title.setStyle('right', width/2 - height); + } + // Rotate the text title.setStyles({ 'transform' : transform, diff --git a/blocks/navigation/styles.css b/blocks/navigation/styles.css index 6da90532f8b..6d08f5ede47 100644 --- a/blocks/navigation/styles.css +++ b/blocks/navigation/styles.css @@ -1,19 +1,23 @@ /** General display rules **/ .block_navigation .block_tree {margin:5px;padding-left:0px;overflow:visible;} .block_navigation .block_tree li {margin:3px;list-style: none;padding:0;} -.block_navigation .block_tree li.item_with_icon > p {position:relative;} -.block_navigation .block_tree li.item_with_icon > p img {vertical-align:middle;position:absolute;left:0;top:3px} +.block_navigation .block_tree li.item_with_icon > p {position:relative; padding-left: 21px;} +.block_navigation .block_tree li.item_with_icon > p img, +.block_navigation .block_tree .type_activity > p.tree_item.active_tree_node img, +.block_navigation .block_tree li > p.hasicon img {vertical-align:middle;position:absolute;left:0;top:-1px;width:16px;height:16px;} .block_navigation .block_tree li.item_with_icon.contains_branch > p img {left:16px;} -.block_navigation .block_tree li.item_with_icon.contains_branch .tree_item {padding-left:34px;} +.block_navigation .block_tree .type_activity > p.branch.hasicon, +.block_navigation .block_tree li.item_with_icon.contains_branch > .tree_item {padding-left:37px;} .block_navigation .block_tree li ul {padding-left:0;margin:0;} .block_navigation .block_tree li.depth_2 ul {padding-left:16px;margin:0;} -.block_navigation .block_tree .tree_item {padding-left: 18px;margin:3px 0px;text-align:left;} +.block_navigation .block_tree .type_activity > p.tree_item.branch.hasicon.active_tree_node, +.block_navigation .block_tree .tree_item {padding-left: 21px;margin:3px 0px;text-align:left;} -.block_navigation .block_tree .tree_item.branch {background-image: url([[pix:t/expanded]]);background-position: 0 10%;background-repeat: no-repeat;} +.block_navigation .block_tree .tree_item.branch {background-image: url([[pix:t/expanded]]);background-position: 0 0;background-repeat: no-repeat;} .block_navigation .block_tree .tree_item.branch.navigation_node {background-image:none;padding-left:0;} .block_navigation .block_tree .type_activity > .tree_item.branch {background-image:none;position:relative;} -.block_navigation .block_tree .type_activity > .tree_item.branch img {position:absolute;left:0;} +.block_navigation .block_tree .type_activity > .tree_item.branch img {left: 16px;} .block_navigation .block_tree .root_node.leaf {padding-left:0px;} .block_navigation .block_tree .active_tree_node {font-weight:bold;} .block_navigation .block_tree .depth_1.current_branch ul {font-weight:normal;} @@ -21,8 +25,9 @@ .dock .block_navigation .tree_item {white-space: nowrap;} .jsenabled .block_navigation .block_tree .tree_item.branch {cursor:pointer;} -.jsenabled .block_navigation .block_tree .tree_item.emptybranch {background-image: url([[pix:t/collapsed_empty]]);background-position: 0% 5%;background-repeat: no-repeat;} +.jsenabled .block_navigation .block_tree .tree_item.emptybranch {background-image: url([[pix:t/collapsed_empty]]);background-position: 0 0;background-repeat: no-repeat;} .jsenabled .block_navigation .block_tree .collapsed ul {display: none;} +.jsenabled .block_navigation .block_tree .type_activity > .tree_item.branch {background-image: url([[pix:t/expanded]]);} .jsenabled .block_navigation .block_tree .collapsed .tree_item.branch {background-image: url([[pix:t/collapsed]]);} .jsenabled .block_navigation .block_tree .tree_item.branch.loadingbranch {background-image:url([[pix:i/loading_small]]);} @@ -35,8 +40,9 @@ .ie6 .block_navigation .block_tree .tree_item {width:100%;} /** Overide for RTL layout **/ -.dir-rtl .block_navigation .block_tree li.depth_2 ul {padding-left:0;padding-right: 7px;} -.dir-rtl .block_navigation .block_tree .tree_item {padding-right: 18px;text-align:right;} +.dir-rtl .block_navigation .block_tree li.depth_2 ul {padding-left:0;padding-right: 16px; padding-left: 0;} +.dir-rtl .block_navigation .block_tree .type_activity > p.tree_item.branch.hasicon.active_tree_node, +.dir-rtl .block_navigation .block_tree .tree_item {padding-right: 21px;text-align:right;} .dir-rtl .block_navigation .block_tree .tree_item.branch {background-position: center right;} @@ -46,7 +52,12 @@ .dir-rtl .block_navigation .block_tree .root_node.leaf {padding-right:0;} .dir-rtl .block_navigation .block_tree li.item_with_icon > p img, -.dir-rtl .block_navigation .block_tree .type_activity > .tree_item.branch img {right:0;left:auto;} +.dir-rtl .block_navigation .block_tree .type_activity > p.tree_item.active_tree_node img, +.dir-rtl .block_navigation .block_tree li > p.hasicon img {left:auto; right:0;} +.dir-rtl .block_navigation .block_tree li.item_with_icon.contains_branch > p img {left: auto; right:16px;} +.dir-rtl .block_navigation .block_tree .type_activity > p.branch.hasicon, +.dir-rtl .block_navigation .block_tree li.item_with_icon.contains_branch > .tree_item {padding-right:37px; padding-left: 0;} +.dir-rtl .block_navigation .block_tree .type_activity > .tree_item.branch img {right: 16px; left: auto;} .jsenabled.dir-rtl .block_navigation .block_tree .tree_item.emptybranch {background-image: url([[pix:t/collapsed_empty_rtl]]);background-position: center right;} .jsenabled.dir-rtl .block_navigation .block_tree .collapsed .tree_item.branch {background-image: url([[pix:t/collapsed_rtl]]);} diff --git a/blocks/participants/block_participants.php b/blocks/participants/block_participants.php index c46a5aa3d66..82889f811c0 100644 --- a/blocks/participants/block_participants.php +++ b/blocks/participants/block_participants.php @@ -37,7 +37,7 @@ class block_participants extends block_list { } } - $icon = ' '; + $icon = ''; $this->content->items[] = ''.$icon.get_string('participants').''; diff --git a/blocks/private_files/renderer.php b/blocks/private_files/renderer.php index e93121986bf..f84d2d7dab6 100644 --- a/blocks/private_files/renderer.php +++ b/blocks/private_files/renderer.php @@ -66,13 +66,13 @@ class block_private_files_renderer extends plugin_renderer_base { $result = ''; diff --git a/blocks/settings/styles.css b/blocks/settings/styles.css index cfa9ab8348c..2c6e4513937 100644 --- a/blocks/settings/styles.css +++ b/blocks/settings/styles.css @@ -6,12 +6,12 @@ /** General display rules **/ .block_settings .block_tree {margin:5px;padding-left:0px;overflow:visible;} .block_settings .block_tree li {margin:0;list-style: none;} -.block_settings .block_tree li ul {padding-left:16px;margin:0;} +.block_settings .block_tree li ul {padding-left:18px;margin:0;} .block_settings .block_tree li.item_with_icon > p {position:relative;} -.block_settings .block_tree li.item_with_icon > p img {vertical-align:middle;position:absolute;left:0;top:-1px} +.block_settings .block_tree li.item_with_icon > p img {vertical-align:middle;position:absolute;left:0;top:-1px; width: 16px; height: 16px;} -.block_settings .block_tree .tree_item {padding-left: 18px;margin:3px 0px;text-align:left;} +.block_settings .block_tree .tree_item {padding-left: 21px;margin:3px 0px;text-align:left;} .block_settings .block_tree .tree_item.branch {background-image: url([[pix:t/expanded]]);background-position: 0 10%;background-repeat: no-repeat;} .block_settings .block_tree .root_node.leaf {padding-left:0px;} @@ -26,12 +26,11 @@ /** Overide for RTL layout **/ .dir-rtl .block_settings .block_tree {padding-right:0px;} -.dir-rtl .block_settings .block_tree li ul {padding-left:0;padding-right: 7px;} -.dir-rtl .block_settings .block_tree li.item_with_icon > p img, -.dir-rtl .block_navigation .block_tree .type_activity > .tree_item.branch img {left:auto;right:0;} -.dir-rtl .block_settings .block_tree .tree_item {padding-right: 18px;text-align:right;} +.dir-rtl .block_settings .block_tree li ul {padding-left:0;padding-right: 18px;} +.dir-rtl .block_settings .block_tree .tree_item {padding-right: 21px; padding-left: 0; text-align:right;} .dir-rtl .block_settings .block_tree .tree_item.branch {background-position: center right;} .dir-rtl .block_settings .block_tree .root_node.leaf {padding-right:0px;} +.dir-rtl .block_settings .block_tree li.item_with_icon > p img { right: 0; left: auto;} .jsenabled.dir-rtl .block_settings .block_tree .tree_item.emptybranch {background-image: url([[pix:t/collapsed_empty_rtl]]);background-position: center right;} -.jsenabled.dir-rtl .block_settings .block_tree .collapsed .tree_item.branch {background-image: url([[pix:t/collapsed_rtl]]);} \ No newline at end of file +.jsenabled.dir-rtl .block_settings .block_tree .collapsed .tree_item.branch {background-image: url([[pix:t/collapsed_rtl]]);} diff --git a/blocks/site_main_menu/block_site_main_menu.php b/blocks/site_main_menu/block_site_main_menu.php index 39a550e5f55..d4374bc122f 100644 --- a/blocks/site_main_menu/block_site_main_menu.php +++ b/blocks/site_main_menu/block_site_main_menu.php @@ -50,7 +50,7 @@ class block_site_main_menu extends block_list { } else { $linkcss = $cm->visible ? '' : ' class="dimmed" '; //Accessibility: incidental image - should be empty Alt text - $icon = ' '; + $icon = ''; $this->content->items[] = 'extra. ' href="' . $url . '">' . $icon . $instancename . ''; } @@ -120,7 +120,7 @@ class block_site_main_menu extends block_list { $this->content->icons[] = ''; } else { //Accessibility: incidental image - should be empty Alt text - $icon = ' '; + $icon = ''; $this->content->items[] = 'extra . ' href="' . $url . '">' . $icon . $instancename . '' . $editbuttons; } diff --git a/grade/lib.php b/grade/lib.php index 67e9f70d9ed..645d73a7f7e 100644 --- a/grade/lib.php +++ b/grade/lib.php @@ -2300,14 +2300,14 @@ function grade_extend_settings($plugininfo, $courseid) { if ($imports = grade_helper::get_plugins_import($courseid)) { $importnode = $gradenode->add($strings['import'], null, navigation_node::TYPE_CONTAINER); foreach ($imports as $import) { - $importnode->add($import->string, $import->link, navigation_node::TYPE_SETTING, null, $import->id, new pix_icon('i/restore', '')); + $importnode->add($import->string, $import->link, navigation_node::TYPE_SETTING, null, $import->id, new pix_icon('i/import', '')); } } if ($exports = grade_helper::get_plugins_export($courseid)) { $exportnode = $gradenode->add($strings['export'], null, navigation_node::TYPE_CONTAINER); foreach ($exports as $export) { - $exportnode->add($export->string, $export->link, navigation_node::TYPE_SETTING, null, $export->id, new pix_icon('i/backup', '')); + $exportnode->add($export->string, $export->link, navigation_node::TYPE_SETTING, null, $export->id, new pix_icon('i/export', '')); } } diff --git a/lib/enrollib.php b/lib/enrollib.php index a045d77e7d2..4691f09cfde 100644 --- a/lib/enrollib.php +++ b/lib/enrollib.php @@ -444,7 +444,7 @@ function enrol_add_course_navigation(navigation_node $coursenode, $course) { if ($course->id == SITEID or (!empty($CFG->adminsassignrolesincourse) and is_siteadmin())) { if (has_capability('moodle/role:assign', $coursecontext)) { $url = new moodle_url('/admin/roles/assign.php', array('contextid'=>$coursecontext->id)); - $permissionsnode->add(get_string('assignedroles', 'role'), $url, navigation_node::TYPE_SETTING, null, 'roles', new pix_icon('i/roles', '')); + $permissionsnode->add(get_string('assignedroles', 'role'), $url, navigation_node::TYPE_SETTING, null, 'roles', new pix_icon('i/rolesm', '')); } } // Check role permissions @@ -459,7 +459,7 @@ function enrol_add_course_navigation(navigation_node $coursenode, $course) { //TODO, create some new UI for role assignments at course level if (has_capability('moodle/role:assign', $coursecontext)) { $url = new moodle_url('/enrol/otherusers.php', array('id'=>$course->id)); - $usersnode->add(get_string('notenrolledusers', 'enrol'), $url, navigation_node::TYPE_SETTING, null, 'otherusers', new pix_icon('i/roles', '')); + $usersnode->add(get_string('notenrolledusers', 'enrol'), $url, navigation_node::TYPE_SETTING, null, 'otherusers', new pix_icon('i/rolesm', '')); } } diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 0f8df494361..5ff2d4b3ca8 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -3527,7 +3527,7 @@ class settings_navigation extends navigation_node { // Import data from other courses if (has_capability('moodle/restore:restoretargetimport', $coursecontext)) { $url = new moodle_url('/backup/import.php', array('id'=>$course->id)); - $coursenode->add(get_string('import'), $url, self::TYPE_SETTING, null, 'import', new pix_icon('i/restore', '')); + $coursenode->add(get_string('import'), $url, self::TYPE_SETTING, null, 'import', new pix_icon('i/import', '')); } // Publish course on a hub @@ -3597,7 +3597,7 @@ class settings_navigation extends navigation_node { $returnurl->param('sesskey', sesskey()); foreach ($roles as $key => $name) { $url = new moodle_url('/course/switchrole.php', array('id'=>$course->id,'sesskey'=>sesskey(), 'switchrole'=>$key, 'returnurl'=>$returnurl->out(false))); - $switchroles->add($name, $url, self::TYPE_SETTING, null, $key, new pix_icon('i/roles', '')); + $switchroles->add($name, $url, self::TYPE_SETTING, null, $key, new pix_icon('i/rolesm', '')); } } // Return we are done @@ -4064,7 +4064,7 @@ class settings_navigation extends navigation_node { // Assign local roles if (has_capability('moodle/role:assign', $this->context)) { $assignurl = new moodle_url('/'.$CFG->admin.'/roles/assign.php', array('contextid'=>$this->context->id)); - $categorynode->add(get_string('assignroles', 'role'), $assignurl, self::TYPE_SETTING, null, 'roles', new pix_icon('i/roles', '')); + $categorynode->add(get_string('assignroles', 'role'), $assignurl, self::TYPE_SETTING, null, 'roles', new pix_icon('i/rolesm', '')); } // Override roles diff --git a/pix/i/export.png b/pix/i/export.png new file mode 100644 index 0000000000000000000000000000000000000000..312f10be722fcdec228cfa5a1f3e9158227d19e4 GIT binary patch literal 265 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`k|nMYCBgY=CFO}lsSJ)O`AMk? zp1FzXsX?iUDV2pMQ*D5XR(rZQhE&{2N;$xsc5cp1{v|98I}B`X|1z7I_EeahXAj~G zc*m+xb|j5MS#Xx*2gySoOVZ}F86qx*C3h;9<=1Y;)!YqS_njaAVh)(7V0g~$+F_Pd1BHu67u@G zNO;WaV!=?A&Sdi81CtsX7o)O)!@uAphNF53hr}IR8u%F)*%&4`nzY(2z1$6SHiM_D KpUXO@geCwt3Rh(S literal 0 HcmV?d00001 diff --git a/pix/i/export.svg b/pix/i/export.svg new file mode 100644 index 00000000000..66e03aab4cf --- /dev/null +++ b/pix/i/export.svg @@ -0,0 +1,16 @@ + + + +]> + + + + + diff --git a/pix/i/import.png b/pix/i/import.png new file mode 100644 index 0000000000000000000000000000000000000000..f2d450b5c37f47339c61e03dffb77b03b3bab6ad GIT binary patch literal 266 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`k|nMYCBgY=CFO}lsSJ)O`AMk? zp1FzXsX?iUDV2pMQ*D5X)_A%&hE&{2N;$xoc5cp1h9$2S-Z}Q=%NMqsS2H9En5$)S z7V#=@1>`U&&)U!0aHUQ`tbt3@;U&ArDW=AUg^b4%9gPd@1f&x-dN6k0Q4`o8rh;v%uj$djkVA!;0O8%q&y>Xan8N N;OXk;vd$@?2>|sCWE=nh literal 0 HcmV?d00001 diff --git a/pix/i/import.svg b/pix/i/import.svg new file mode 100644 index 00000000000..9cc13cd1696 --- /dev/null +++ b/pix/i/import.svg @@ -0,0 +1,16 @@ + + + +]> + + + + + diff --git a/pix/i/rolesm.png b/pix/i/rolesm.png new file mode 100644 index 0000000000000000000000000000000000000000..1005da4a8a0e58f114498ed254f527406ab241e3 GIT binary patch literal 233 zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$1|-8uW1a&k$r9IylHmNblJdl&R0hYC{G?O` z&)mfH)S%SFl*+=BsWw1G-JULvAr-fhQXH6#)6dP}Um~>N4(H34FI!K1^2z9uo*>ff zz!<`_n@yo3{Q%3yA0`?J7Z)`6Gdnh{OJo!?mHv>Kabyu=wFaZJGlOnRf&!x!J6lhH zAEUr?=8X)KeB~Q<$e;SpP#UGoJz+=x5&^a+jWgss`8V4(vUVp4?BFmJW!~_BV=wQH dCQ*e04B@k7C#`b2KO5*Q22WQ%mvv4FO#tWZO~?QM literal 0 HcmV?d00001 diff --git a/pix/i/rolesm.svg b/pix/i/rolesm.svg new file mode 100644 index 00000000000..f4cc25adb4b --- /dev/null +++ b/pix/i/rolesm.svg @@ -0,0 +1,15 @@ + + + +]> + + + + + diff --git a/theme/base/style/blocks.css b/theme/base/style/blocks.css index c8b24844793..6e702cec4be 100644 --- a/theme/base/style/blocks.css +++ b/theme/base/style/blocks.css @@ -2,7 +2,7 @@ .block .header h2 {margin:4px;} .block .header .block_action {float:right;margin:2px 4px 0;vertical-align:top;} .block .header .block_action input {margin-right:2px;} -.block .header .commands {margin-left:4px;} +.block .header .commands { text-align: right;} .block .header .commands .icon img {width:12px;height:12px;margin-right:3px;} .block .content {padding:4px;} .block.hidden .content {display: none;} @@ -32,4 +32,5 @@ /** Overide for RTL layout **/ .dir-rtl .block .header, .dir-rtl .block h2.header {text-align:right;} -.dir-rtl .block .header .commands { text-align: right;} \ No newline at end of file +.dir-rtl .block .header .commands { text-align: left;} +.dir-rtl .block .header .block_action { float: left; margin-left: 4px; margin-left: 0;} diff --git a/theme/base/style/core.css b/theme/base/style/core.css index 2b26b5e93a0..a7b16b40693 100644 --- a/theme/base/style/core.css +++ b/theme/base/style/core.css @@ -89,7 +89,8 @@ a.autolink.glossary:hover {cursor: help;} img.resize {height: 1em;width: 1em;} .block img.resize, .breadcrumb img.resize {height: 0.9em;width: 0.8em;} -img.icon {height:16px;vertical-align:middle;width:16px;padding-right:4px;padding-top:2px;padding-bottom:2px;} +img.icon {height:16px;vertical-align:text-bottom;width:16px;padding: 2px 6px 2px 0;} +.dir-rtl img.icon {padding: 2px 0 2px 6px;} img.iconsmall {height:12px;margin-right:3px;vertical-align:middle;width:12px;} img.iconhelp, .helplink img {height:16px; padding-left:3px;vertical-align:middle;width:16px;} img.iconlarge {height: 24px; width: 24px; vertical-align:middle;} diff --git a/theme/base/style/dock.css b/theme/base/style/dock.css index 97f866016e5..a2519bc0134 100644 --- a/theme/base/style/dock.css +++ b/theme/base/style/dock.css @@ -23,19 +23,17 @@ body.has_dock {margin-left:30px;} #dockeditempanel .dockeditempanel_bd {overflow:auto;width:auto;} #dockeditempanel .dockeditempanel_bd .block_docked {margin:10px;} #dockeditempanel .dockeditempanel_bd .block_navigation .block_tree li {overflow:visible;} -#dockeditempanel .dockeditempanel_hd {border-bottom:1px solid #000;text-align:right;} -#dockeditempanel .dockeditempanel_hd h2 {display:inline;margin:0;padding-right:1em;} -#dockeditempanel .dockeditempanel_hd .commands {display:inline;} +#dockeditempanel .dockeditempanel_hd {border-bottom:1px solid #000;} +#dockeditempanel .dockeditempanel_hd h2 {display:block;margin:0;padding-right:1em;} +#dockeditempanel .dockeditempanel_hd .commands {display:block;text-align:right;} #dockeditempanel .dockeditempanel_hd .commands img {margin-right:2px;vertical-align:middle;} /** IE 6 doesn't support fixed pos elements **/ .ie6 #dockeditempanel {position:absolute;} -/** Overide for RTL layout **/ -.dir-rtl #dockeditempanel {left:670%;} - /* right align the DOCK panel ------------------------------*/ +.dir-rtl #dockeditempanel .dockeditempanel_hd .commands {text-align: left;} .dir-rtl #dockeditempanel {right: 100%;} .dir-rtl #dock {left:auto;right: 0%; border-left: 1px solid #DDD;} .dir-rtl #dock .dockedtitle { border-bottom: 1px solid #DDD;border-top: 1px solid #EEE; cursor: pointer;} diff --git a/theme/upgrade.txt b/theme/upgrade.txt index 9dec36e942d..e85a6e456b6 100644 --- a/theme/upgrade.txt +++ b/theme/upgrade.txt @@ -10,6 +10,8 @@ optional changes: * new optional boolean parameter $withlinks for public function login_info() in lib/outputrenderers.php (MDL-31365) * new layout option "nologinlinks" and new page layout "secure" e.g. for safebrowser and securewindow (MDL-31365) * new class 'iconlarge' for 24x24 icons. +* new icons i/export and i/import. Previously export and import actions used i/backup and i/restore. +* new icon i/rolesm (stands for 'roles medium') is 16x16 instead of 12x12 for i/roles === 2.3 === From 045d946ccc1326dc886976e4839668fe734d2642 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Tue, 13 Nov 2012 13:57:21 +0800 Subject: [PATCH 2/5] MDL-36323 usability: CSS for block headers --- blocks/dock.js | 2 +- theme/base/style/blocks.css | 12 +++++++----- theme/base/style/dock.css | 10 +++++++--- theme/standard/style/blocks.css | 8 ++------ theme/standard/style/dock.css | 6 +++--- 5 files changed, 20 insertions(+), 18 deletions(-) diff --git a/blocks/dock.js b/blocks/dock.js index 7aa22e34ee1..ca685d53fed 100644 --- a/blocks/dock.js +++ b/blocks/dock.js @@ -928,7 +928,7 @@ M.core_dock.genericblock.prototype = { }, this); // Add a close icon // Must set the image src seperatly of we get an error with XML strict headers - var closeicon = Y.Node.create(''); + var closeicon = Y.Node.create(''); closeicon.one('img').setAttribute('src', M.util.image_url('t/dockclose', 'moodle')); closeicon.on('forceclose|click', this.hide, this); closeicon.on('dock:actionkey',this.hide, this, {actions:{enter:true,toggle:true}}); diff --git a/theme/base/style/blocks.css b/theme/base/style/blocks.css index 6e702cec4be..7283d491c1e 100644 --- a/theme/base/style/blocks.css +++ b/theme/base/style/blocks.css @@ -1,9 +1,11 @@ .block {border:1px solid;margin-bottom:1em;} -.block .header h2 {margin:4px;} -.block .header .block_action {float:right;margin:2px 4px 0;vertical-align:top;} -.block .header .block_action input {margin-right:2px;} -.block .header .commands { text-align: right;} -.block .header .commands .icon img {width:12px;height:12px;margin-right:3px;} +.block .header h2 { padding: .2em 0 0 .2em; margin: 0;} +.block .header .block_action {float:right;margin:4px 0 3px 0;vertical-align:top;} +.block .header .block_action img, +.block .header .block_action input {margin:0 3px; width: 12px; height: 12px;} +.block .header .commands { text-align: right; clear: both;} +.block .header .commands > a { margin:0 3px; } +.block .header .commands .icon img {width:12px;height:12px;} .block .content {padding:4px;} .block.hidden .content {display: none;} .block .content .userpicture {width:16px;height:16px;margin-right:4px;} diff --git a/theme/base/style/dock.css b/theme/base/style/dock.css index a2519bc0134..a5fb7ff6ba2 100644 --- a/theme/base/style/dock.css +++ b/theme/base/style/dock.css @@ -11,7 +11,7 @@ body.has_dock {margin-left:30px;} #dock.nothingdocked {visibility: hidden;display:none;} #dock .dockeditem .firstdockitem {margin-top:1em;} #dock .dockedtitle {border-bottom:1px solid #000;border-top:1px solid #000;cursor:pointer;} -#dock .dockedtitle h2 {font-size:0.8em;line-height:100%;text-align:center;} +#dock .dockedtitle h2 {font-size:0.80em;line-height:100%;text-align:center;} #dock .dockedtitle .filterrotate {margin-left:8px;} #dock .controls {position:absolute;bottom:1em;text-align:center;width:100%;} #dock .controls img {cursor:pointer;} @@ -26,7 +26,11 @@ body.has_dock {margin-left:30px;} #dockeditempanel .dockeditempanel_hd {border-bottom:1px solid #000;} #dockeditempanel .dockeditempanel_hd h2 {display:block;margin:0;padding-right:1em;} #dockeditempanel .dockeditempanel_hd .commands {display:block;text-align:right;} -#dockeditempanel .dockeditempanel_hd .commands img {margin-right:2px;vertical-align:middle;} +#dockeditempanel .dockeditempanel_hd .commands > a, +#dockeditempanel .dockeditempanel_hd .commands > span { margin:0 3px; } +#dockeditempanel .dockeditempanel_hd .commands img, +#dockeditempanel .dockeditempanel_hd .commands input {vertical-align:middle; width: 12px; height: 12px;} +#dockeditempanel .dockeditempanel_hd .commands .hidepanemicon img { cursor:pointer; } /** IE 6 doesn't support fixed pos elements **/ .ie6 #dockeditempanel {position:absolute;} @@ -37,4 +41,4 @@ body.has_dock {margin-left:30px;} .dir-rtl #dockeditempanel {right: 100%;} .dir-rtl #dock {left:auto;right: 0%; border-left: 1px solid #DDD;} .dir-rtl #dock .dockedtitle { border-bottom: 1px solid #DDD;border-top: 1px solid #EEE; cursor: pointer;} -body.dir-rtl.has_dock {margin-left: 0px; margin-right: 30px} \ No newline at end of file +body.dir-rtl.has_dock {margin-left: 0px; margin-right: 30px} diff --git a/theme/standard/style/blocks.css b/theme/standard/style/blocks.css index 8283217c2aa..45fbd70251b 100644 --- a/theme/standard/style/blocks.css +++ b/theme/standard/style/blocks.css @@ -1,19 +1,15 @@ /** General **/ .block {border:1px solid #DDD;} .block .header {border-bottom:1px solid #DDD;border-color: #dddddd;} -.block .header h2 {margin-top:2px;font-size:1em;} -.block .header .block_action {margin:0 4px;} -.block .header .block_action img, -.block .header .block_action input {width:11px; height:11px;} +.block .header h2 {font-size:1em;} .block .content {border-color: #dddddd;background-color:#FCFCFC;} .block .content hr {border-top-color:#999999;} .block .header .commands {font-size:0.9em;clear:both;} -.block .header .commands .icon {margin-right:2px;} .block .footer {font-size:0.9em;text-align:center;clear:both;} .block.beingmoved {border-color: #f88;} .block .header, -.block h2.header {text-align: left;margin:0;padding:4px;padding-top:0;border-bottom-width: 0;} +.block h2.header {text-align: left;margin:0;padding:4px;border-bottom-width: 0;} .block .content h2 {text-align: left;margin:1.5em 0 0;padding:0;} .block .content h3 {text-align: left;} .dir-rtl .block .content h3 {text-align: right;} diff --git a/theme/standard/style/dock.css b/theme/standard/style/dock.css index 760483508b7..fd43db31891 100644 --- a/theme/standard/style/dock.css +++ b/theme/standard/style/dock.css @@ -9,8 +9,8 @@ /** For the panel the docked blocks are shown in */ #dockeditempanel .dockeditempanel_content {border-color:#AAA;} -#dockeditempanel .dockeditempanel_hd {border-bottom-color:#AAA;padding:3px 5px;background-image:url([[pix:theme|hgradient]]);} -#dockeditempanel .dockeditempanel_hd h2 {font-size:80%;color:#999;} +#dockeditempanel .dockeditempanel_hd {border-bottom-color:#AAA;padding:4px;background-image:url([[pix:theme|hgradient]]);} +#dockeditempanel .dockeditempanel_hd h2 {font-size:95%;color:#999;} /* block expansion code */ .block_js_expansion .block_tree {overflow-x:scroll;} @@ -25,4 +25,4 @@ .ie6 #dock li p {background-color:inherit;} .ie6 #dock .bd.oversized_content .content, .ie7 #dock .bd.oversized_content .content {padding-bottom:0px;} .ie6 .block_js_expansion.mouseover .content, .ie7 .block_js_expansion.mouseover .content{ padding-bottom:2px;} -.ie6 #dock .bd.oversized_content {width:100%;} \ No newline at end of file +.ie6 #dock .bd.oversized_content {width:100%;} From 57dba028133d2345b2ce8cc70f2b7b39ef587a6b Mon Sep 17 00:00:00 2001 From: Barbara Ramiro Date: Tue, 13 Nov 2012 15:06:30 +0800 Subject: [PATCH 3/5] MDL-36323 usability: Resized icons to 16x16 --- pix/i/item.png | Bin 173 -> 171 bytes pix/i/item.svg | 2 +- pix/i/navigationitem.png | Bin 150 -> 150 bytes pix/i/navigationitem.svg | 2 +- pix/t/collapsed.png | Bin 182 -> 187 bytes pix/t/collapsed.svg | 4 ++-- pix/t/collapsed_empty.png | Bin 206 -> 210 bytes pix/t/collapsed_empty.svg | 4 ++-- pix/t/collapsed_empty_rtl.png | Bin 208 -> 218 bytes pix/t/collapsed_empty_rtl.svg | 4 ++-- pix/t/collapsed_rtl.png | Bin 175 -> 181 bytes pix/t/collapsed_rtl.svg | 4 ++-- pix/t/expanded.png | Bin 172 -> 181 bytes pix/t/expanded.svg | 4 ++-- 14 files changed, 12 insertions(+), 12 deletions(-) diff --git a/pix/i/item.png b/pix/i/item.png index 25ce1890edeac07364063b0e8ba98660883513a6..0da3dd02009aa7fc6097f4beea9aeebb5a2d34ad 100644 GIT binary patch delta 140 zcmZ3>xSCP1Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}BUucwP+NX4zB1PN9V zX19{Yna1f{3@d*-=rpK(RkXE@6^OMJ=4)o{5IJnZka3z_Wu2mc^`p;B!b=kmI63^Y oQDiRI`G9$1(&7dw289C*IVZSER)?7O0xe+hboFyt=akR{04%pDb^rhX delta 142 zcmZ3@xRz0|Gr-TCmrII^fq{Y7)59eQNb`U&2OE$KD~)+RQBfns-_yl0q~camf<#G! z;ISE&#mg8b?BYMdl#yk(WchOLLl!<6lb9lSTm_r68D@QA^t>a`Wyl~b_dIEHZzF5_ qqt82h9JfDY7BiKXU^8dnFko0y!Bw*Cv*t>m6%3xPelF{r5}E)s4J;x6 diff --git a/pix/i/item.svg b/pix/i/item.svg index 22132cd7d0f..56884a21713 100644 --- a/pix/i/item.svg +++ b/pix/i/item.svg @@ -5,7 +5,7 @@ ]> diff --git a/pix/i/navigationitem.png b/pix/i/navigationitem.png index 0bc08cc81c6e8cea8ff587e66f2d1f6dc2562cea..1e831d389a6d3176d3bcb369721b5dd45f177d03 100644 GIT binary patch delta 109 zcmbQnIE_)UGr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qN0&As|d4OPLpx^xf=c@ zEEihrmn>h-y=Zmnp~MXg6O$}>6{L9LnC%2K&A3)DGBEKlL~yh7uuXG%3^akk)78&q Iol`;+0FX5sY5)KL delta 109 zcmbQnIE_)UGr-TCmrII^fq{Y7)59eQNb`U&2OE$KD~)+RQPIe`q(N||aq+V=-yOUd ze9yLj`BLI2(az}`#L&G^BgtopRp&n`yM(~cjfn-!4Ghc-bAPb&C|SO{3^akk)78&q Iol`;+09q*_bpQYW diff --git a/pix/i/navigationitem.svg b/pix/i/navigationitem.svg index 7fd7231e61b..055d3c3300a 100644 --- a/pix/i/navigationitem.svg +++ b/pix/i/navigationitem.svg @@ -5,7 +5,7 @@ ]> diff --git a/pix/t/collapsed.png b/pix/t/collapsed.png index 12da3ad045307d95122672be07db6463cf43fc66..75d64e6162c39917489bf562bf352edc4bc0657d 100644 GIT binary patch delta 156 zcmdnSxSLV2Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}Aotfz}(NX4zB1c@mL z&(6$z-*}@zVylnE5!QwZd&4$^hZB`g38*oN37E8Wa^ycUZRtEwz$)$3$;dOMf|13J zVWaX+wg%JX%a_M19B0@wi&N4ez}Swt + x="0px" y="0px" width="16px" height="16px" viewBox="-5 -2.1 16 16" + style="overflow:visible;enable-background:new -5 -2.1 16 16;" xml:space="preserve"> diff --git a/pix/t/collapsed_empty.png b/pix/t/collapsed_empty.png index fb07d0dc11aeb7068f47f8c512e56bb3bda835bf..24b80e928e21c72530d2d155be73101c3bed5b43 100644 GIT binary patch delta 180 zcmX@dc!^Q5Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}B9iKmNWNX4zB1c@mL z&(6$z-*}@zVylnE5!QwZd&4#Z!3pXa9Cpk+jXxL_oeQKU%$vt|>5az;fjw~yQlA)a z3KSh`Xk6sLVinDhwVCOP>Je#%D{C6oNWPfMedEf;2ZaYJHF|@M4HFx}jqRB21Qu5o fFf=eQGn}2QvF^gw& + x="0px" y="0px" width="16px" height="16px" viewBox="-5 -2.1 16 16" + style="overflow:visible;enable-background:new -5 -2.1 16 16;" xml:space="preserve"> + x="0px" y="0px" width="16px" height="16px" viewBox="-5 -2.1 16 16" + style="overflow:visible;enable-background:new -5 -2.1 16 16;" xml:space="preserve"> + x="0px" y="0px" width="16px" height="16px" viewBox="-5 -2.1 16 16" + style="overflow:visible;enable-background:new -5 -2.1 16 16;" xml:space="preserve"> diff --git a/pix/t/expanded.png b/pix/t/expanded.png index bd7ed3ea5724778b10fe25e6a49c42a84c1924df..e1570ebbfbc842650392b6a995778d4ef778aacf 100644 GIT binary patch delta 150 zcmZ3(xRp_{Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}AlxTlL_NX4zB1PN9V zW;coCXJ=-r{Va0A-F;OXk;vd$@?2>@XIE7br1 diff --git a/pix/t/expanded.svg b/pix/t/expanded.svg index 6e96c042ed0..459eeb0d4cc 100644 --- a/pix/t/expanded.svg +++ b/pix/t/expanded.svg @@ -5,8 +5,8 @@ ]> + x="0px" y="0px" width="16px" height="16px" viewBox="-2.1 -5 16 16" + style="overflow:visible;enable-background:new -2.1 -5 16 16;" xml:space="preserve"> From fbb207c57a86c4340593da2efa345dcd43372f75 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Tue, 13 Nov 2012 16:48:50 +0800 Subject: [PATCH 4/5] MDL-36323 usability: New icon names to assign and switch roles --- course/lib.php | 2 +- lib/blocklib.php | 2 +- lib/enrollib.php | 4 ++-- lib/navigationlib.php | 4 ++-- pix/i/{roles.png => assignroles.png} | Bin pix/i/{roles.svg => assignroles.svg} | 0 pix/i/{rolesm.png => switchrole.png} | Bin pix/i/{rolesm.svg => switchrole.svg} | 0 pix/t/assignroles.png | Bin 0 -> 233 bytes pix/t/assignroles.svg | 15 +++++++++++++++ theme/upgrade.txt | 8 ++++++-- 11 files changed, 27 insertions(+), 8 deletions(-) rename pix/i/{roles.png => assignroles.png} (100%) rename pix/i/{roles.svg => assignroles.svg} (100%) rename pix/i/{rolesm.png => switchrole.png} (100%) rename pix/i/{rolesm.svg => switchrole.svg} (100%) create mode 100644 pix/t/assignroles.png create mode 100644 pix/t/assignroles.svg diff --git a/course/lib.php b/course/lib.php index dab4668dda7..c3a4165df14 100644 --- a/course/lib.php +++ b/course/lib.php @@ -3315,7 +3315,7 @@ function make_editing_buttons(stdClass $mod, $absolute_ignored = true, $movesele if (has_capability('moodle/role:assign', $modcontext)){ $actions[] = new action_link( new moodle_url('/'.$CFG->admin.'/roles/assign.php', array('contextid' => $modcontext->id)), - new pix_icon('i/roles', $str->assign, 'moodle', array('class' => 'iconsmall', 'title' => '')), + new pix_icon('t/assignroles', $str->assign, 'moodle', array('class' => 'iconsmall', 'title' => '')), null, array('class' => 'editing_assign', 'title' => $str->assign) ); diff --git a/lib/blocklib.php b/lib/blocklib.php index c28c9193b05..e56693300ae 100644 --- a/lib/blocklib.php +++ b/lib/blocklib.php @@ -1067,7 +1067,7 @@ class block_manager { $controls[] = array('url' => $CFG->wwwroot . '/' . $CFG->admin . '/roles/assign.php?contextid=' . $block->context->id . '&returnurl=' . urlencode($return), - 'icon' => 'i/roles', 'caption' => get_string('assignroles', 'role'), 'class' => 'editing_roles'); + 'icon' => 't/assignroles', 'caption' => get_string('assignroles', 'role'), 'class' => 'editing_roles'); } return $controls; diff --git a/lib/enrollib.php b/lib/enrollib.php index 4691f09cfde..835a07a4b14 100644 --- a/lib/enrollib.php +++ b/lib/enrollib.php @@ -444,7 +444,7 @@ function enrol_add_course_navigation(navigation_node $coursenode, $course) { if ($course->id == SITEID or (!empty($CFG->adminsassignrolesincourse) and is_siteadmin())) { if (has_capability('moodle/role:assign', $coursecontext)) { $url = new moodle_url('/admin/roles/assign.php', array('contextid'=>$coursecontext->id)); - $permissionsnode->add(get_string('assignedroles', 'role'), $url, navigation_node::TYPE_SETTING, null, 'roles', new pix_icon('i/rolesm', '')); + $permissionsnode->add(get_string('assignedroles', 'role'), $url, navigation_node::TYPE_SETTING, null, 'roles', new pix_icon('i/assignroles', '')); } } // Check role permissions @@ -459,7 +459,7 @@ function enrol_add_course_navigation(navigation_node $coursenode, $course) { //TODO, create some new UI for role assignments at course level if (has_capability('moodle/role:assign', $coursecontext)) { $url = new moodle_url('/enrol/otherusers.php', array('id'=>$course->id)); - $usersnode->add(get_string('notenrolledusers', 'enrol'), $url, navigation_node::TYPE_SETTING, null, 'otherusers', new pix_icon('i/rolesm', '')); + $usersnode->add(get_string('notenrolledusers', 'enrol'), $url, navigation_node::TYPE_SETTING, null, 'otherusers', new pix_icon('i/assignroles', '')); } } diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 5ff2d4b3ca8..0fd249691c8 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -3597,7 +3597,7 @@ class settings_navigation extends navigation_node { $returnurl->param('sesskey', sesskey()); foreach ($roles as $key => $name) { $url = new moodle_url('/course/switchrole.php', array('id'=>$course->id,'sesskey'=>sesskey(), 'switchrole'=>$key, 'returnurl'=>$returnurl->out(false))); - $switchroles->add($name, $url, self::TYPE_SETTING, null, $key, new pix_icon('i/rolesm', '')); + $switchroles->add($name, $url, self::TYPE_SETTING, null, $key, new pix_icon('i/switchrole', '')); } } // Return we are done @@ -4064,7 +4064,7 @@ class settings_navigation extends navigation_node { // Assign local roles if (has_capability('moodle/role:assign', $this->context)) { $assignurl = new moodle_url('/'.$CFG->admin.'/roles/assign.php', array('contextid'=>$this->context->id)); - $categorynode->add(get_string('assignroles', 'role'), $assignurl, self::TYPE_SETTING, null, 'roles', new pix_icon('i/rolesm', '')); + $categorynode->add(get_string('assignroles', 'role'), $assignurl, self::TYPE_SETTING, null, 'roles', new pix_icon('i/assignroles', '')); } // Override roles diff --git a/pix/i/roles.png b/pix/i/assignroles.png similarity index 100% rename from pix/i/roles.png rename to pix/i/assignroles.png diff --git a/pix/i/roles.svg b/pix/i/assignroles.svg similarity index 100% rename from pix/i/roles.svg rename to pix/i/assignroles.svg diff --git a/pix/i/rolesm.png b/pix/i/switchrole.png similarity index 100% rename from pix/i/rolesm.png rename to pix/i/switchrole.png diff --git a/pix/i/rolesm.svg b/pix/i/switchrole.svg similarity index 100% rename from pix/i/rolesm.svg rename to pix/i/switchrole.svg diff --git a/pix/t/assignroles.png b/pix/t/assignroles.png new file mode 100644 index 0000000000000000000000000000000000000000..1005da4a8a0e58f114498ed254f527406ab241e3 GIT binary patch literal 233 zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$1|-8uW1a&k$r9IylHmNblJdl&R0hYC{G?O` z&)mfH)S%SFl*+=BsWw1G-JULvAr-fhQXH6#)6dP}Um~>N4(H34FI!K1^2z9uo*>ff zz!<`_n@yo3{Q%3yA0`?J7Z)`6Gdnh{OJo!?mHv>Kabyu=wFaZJGlOnRf&!x!J6lhH zAEUr?=8X)KeB~Q<$e;SpP#UGoJz+=x5&^a+jWgss`8V4(vUVp4?BFmJW!~_BV=wQH dCQ*e04B@k7C#`b2KO5*Q22WQ%mvv4FO#tWZO~?QM literal 0 HcmV?d00001 diff --git a/pix/t/assignroles.svg b/pix/t/assignroles.svg new file mode 100644 index 00000000000..f4cc25adb4b --- /dev/null +++ b/pix/t/assignroles.svg @@ -0,0 +1,15 @@ + + + +]> + + + + + diff --git a/theme/upgrade.txt b/theme/upgrade.txt index e85a6e456b6..ce15db20614 100644 --- a/theme/upgrade.txt +++ b/theme/upgrade.txt @@ -6,12 +6,16 @@ information provided here is intended especially for theme designer. required changes: * output course and course content header/footer that may be returned by course format (see MDL-36048) +deprecation: +* i/roles: Use t/assignroles instead + optional changes: * new optional boolean parameter $withlinks for public function login_info() in lib/outputrenderers.php (MDL-31365) * new layout option "nologinlinks" and new page layout "secure" e.g. for safebrowser and securewindow (MDL-31365) * new class 'iconlarge' for 24x24 icons. -* new icons i/export and i/import. Previously export and import actions used i/backup and i/restore. -* new icon i/rolesm (stands for 'roles medium') is 16x16 instead of 12x12 for i/roles +* new icons i/export and i/import (sized 16x16). Previously export and import actions used i/backup and i/restore. +* new icon i/assignroles (sized 16x16), to prevent the use of i/roles which is 12x12. +* new icon i/switchrole (sized 16x16), was previously using i/roles. Now is a copy of the new i/assignroles icon. === 2.3 === From b7494afe49d6c9c832615faefdbc29f0fe0e2bc0 Mon Sep 17 00:00:00 2001 From: Barbara Ramiro Date: Tue, 13 Nov 2012 16:49:34 +0800 Subject: [PATCH 5/5] MDL-36323 usability: Final icons for i/assignroles and i/switchrole --- pix/i/assignroles.png | Bin 233 -> 289 bytes pix/i/assignroles.svg | 8 ++++---- pix/i/switchrole.png | Bin 233 -> 289 bytes pix/i/switchrole.svg | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pix/i/assignroles.png b/pix/i/assignroles.png index 1005da4a8a0e58f114498ed254f527406ab241e3..77011dbfc200f1c9707b1d448b86bc6f4e9346ea 100644 GIT binary patch delta 259 zcmaFKxR6P)Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}CqVNVywkcwMLDF>L+ z&dteWSn{j!2BTI9LkIWe%a`>RtWG_$D3ZbBE_)KA$x42QH5?{Sm^Ud1i?M%6zIcW~ zbhW$qku(Pe=DZ0GJ&a5hJOT>G7$!0J@kz(j zrzW*UObX|Y3rZ`9`#AVT`t*3r;$FbX8kwvZ^vKC?qHrRcA(N?^gQ?a7jxGEF;f4vG zw}c}bj?~yRmQ8S2v?^Uu;4Hg_r-!)1LO$M~+&e@VStJ<#PBf~MJj4w0DTAl0pUXO@ GgeCw!*Hha7 delta 203 zcmZ3;^pa7rGr-TCmrII^fq{Y7)59eQNb`U&2OE$KD~)+RQBkA5+tbA{q~camiUYH8 z`nfs$ON18O;e7e>W$TGgJ{euo6GWOF7(;k=vnh0>A7J_T!$c$D;(`W$X2*tgiHu^V z(jPK2jx1uV)?jpYX3%X(P+-(zXX^>@V-$GKypds&uYAJ}`BVQHN~4syC+z57BEa^f zafW;+|7P1p*6t*M9UP{LqRbl}aO~yX(Il#HfFXRg?4(sr_h$p$$KdJe=d#Wzp$P!P C07O{; diff --git a/pix/i/assignroles.svg b/pix/i/assignroles.svg index f4cc25adb4b..7521139dbd5 100644 --- a/pix/i/assignroles.svg +++ b/pix/i/assignroles.svg @@ -5,11 +5,11 @@ ]> - + diff --git a/pix/i/switchrole.png b/pix/i/switchrole.png index 1005da4a8a0e58f114498ed254f527406ab241e3..77011dbfc200f1c9707b1d448b86bc6f4e9346ea 100644 GIT binary patch delta 259 zcmaFKxR6P)Gr-TCmrII^fq{Y7)59eQNDF{42OE%-|NK93qM}CqVNVywkcwMLDF>L+ z&dteWSn{j!2BTI9LkIWe%a`>RtWG_$D3ZbBE_)KA$x42QH5?{Sm^Ud1i?M%6zIcW~ zbhW$qku(Pe=DZ0GJ&a5hJOT>G7$!0J@kz(j zrzW*UObX|Y3rZ`9`#AVT`t*3r;$FbX8kwvZ^vKC?qHrRcA(N?^gQ?a7jxGEF;f4vG zw}c}bj?~yRmQ8S2v?^Uu;4Hg_r-!)1LO$M~+&e@VStJ<#PBf~MJj4w0DTAl0pUXO@ GgeCw!*Hha7 delta 203 zcmZ3;^pa7rGr-TCmrII^fq{Y7)59eQNb`U&2OE$KD~)+RQBkA5+tbA{q~camiUYH8 z`nfs$ON18O;e7e>W$TGgJ{euo6GWOF7(;k=vnh0>A7J_T!$c$D;(`W$X2*tgiHu^V z(jPK2jx1uV)?jpYX3%X(P+-(zXX^>@V-$GKypds&uYAJ}`BVQHN~4syC+z57BEa^f zafW;+|7P1p*6t*M9UP{LqRbl}aO~yX(Il#HfFXRg?4(sr_h$p$$KdJe=d#Wzp$P!P C07O{; diff --git a/pix/i/switchrole.svg b/pix/i/switchrole.svg index f4cc25adb4b..7521139dbd5 100644 --- a/pix/i/switchrole.svg +++ b/pix/i/switchrole.svg @@ -5,11 +5,11 @@ ]> - +