From ebcd41cac2cd82bc1a19d7ff1be0880130b996c8 Mon Sep 17 00:00:00 2001
From: Sam Hemelryk <sam@moodle.com>
Date: Tue, 24 Nov 2009 04:03:35 +0000
Subject: [PATCH] upgrade MDL-20933 Fixed warning if get_records_sql returned
 false rather than an array

---
 lib/db/upgrade.php | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 2fc0df04c99..b2d2af82c0f 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -839,9 +839,10 @@ function xmldb_main_upgrade($oldversion=0) {
                        AND u.deleted = 0
                        AND rc.contextid = ".$systemcontext->id." AND u.auth<>'manual' AND u.auth<>'email'";
 
-        $adminusers = get_records_sql($sql);
-        foreach ($adminusers as $adminuser) {
-            delete_records('user_preferences', 'userid', $adminuser->id, 'name', 'auth_forcepasswordchange');
+        if ($adminusers = get_records_sql($sql)) {
+            foreach ($adminusers as $adminuser) {
+                delete_records('user_preferences', 'userid', $adminuser->id, 'name', 'auth_forcepasswordchange');
+            }
         }
         unset($adminusers);
     }