diff --git a/admin/tool/log/store/database/tests/store_test.php b/admin/tool/log/store/database/tests/store_test.php index 90add2732c8..0a833172ce8 100644 --- a/admin/tool/log/store/database/tests/store_test.php +++ b/admin/tool/log/store/database/tests/store_test.php @@ -310,17 +310,16 @@ class store_test extends \advanced_testcase { $logmanager = get_log_manager(); $allreports = \core_component::get_plugin_list('report'); - $supportedreports = array( - 'report_log' => '/report/log', - 'report_loglive' => '/report/loglive' - ); - // Make sure all supported reports are installed. - $expectedreports = array_keys(array_intersect_key($allreports, $supportedreports)); - $reports = $logmanager->get_supported_reports('logstore_database'); - $reports = array_keys($reports); + $expectedreports = array_intersect_key([ + 'log' => 'report_log', + 'loglive' => 'report_loglive', + ], $allreports); + + $supportedreports = $logmanager->get_supported_reports('logstore_database'); + foreach ($expectedreports as $expectedreport) { - $this->assertContains($expectedreport, $reports); + $this->assertArrayHasKey($expectedreport, $supportedreports); } } } diff --git a/admin/tool/log/store/legacy/tests/store_test.php b/admin/tool/log/store/legacy/tests/store_test.php index c55121ff75e..611d8c13daf 100644 --- a/admin/tool/log/store/legacy/tests/store_test.php +++ b/admin/tool/log/store/legacy/tests/store_test.php @@ -217,20 +217,19 @@ class store_test extends \advanced_testcase { $logmanager = get_log_manager(); $allreports = \core_component::get_plugin_list('report'); - $supportedreports = array( - 'report_log' => '/report/log', - 'report_loglive' => '/report/loglive', - 'report_outline' => '/report/outline', - 'report_participation' => '/report/participation', - 'report_stats' => '/report/stats' - ); - // Make sure all supported reports are installed. - $expectedreports = array_keys(array_intersect_key($allreports, $supportedreports)); - $reports = $logmanager->get_supported_reports('logstore_legacy'); - $reports = array_keys($reports); + $expectedreports = array_intersect_key([ + 'log' => 'report_log', + 'loglive' => 'report_loglive', + 'outline' => 'report_outline', + 'participation' => 'report_participation', + 'stats' => 'report_stats' + ], $allreports); + + $supportedreports = $logmanager->get_supported_reports('logstore_legacy'); + foreach ($expectedreports as $expectedreport) { - $this->assertContains($expectedreport, $reports); + $this->assertArrayHasKey($expectedreport, $supportedreports); } } diff --git a/admin/tool/log/store/standard/tests/store_test.php b/admin/tool/log/store/standard/tests/store_test.php index ca385c46206..5358143e59c 100644 --- a/admin/tool/log/store/standard/tests/store_test.php +++ b/admin/tool/log/store/standard/tests/store_test.php @@ -242,20 +242,19 @@ class store_test extends \advanced_testcase { $logmanager = get_log_manager(); $allreports = \core_component::get_plugin_list('report'); - $supportedreports = array( - 'report_log' => '/report/log', - 'report_loglive' => '/report/loglive', - 'report_outline' => '/report/outline', - 'report_participation' => '/report/participation', - 'report_stats' => '/report/stats' - ); - // Make sure all supported reports are installed. - $expectedreports = array_keys(array_intersect_key($allreports, $supportedreports)); - $reports = $logmanager->get_supported_reports('logstore_standard'); - $reports = array_keys($reports); + $expectedreports = array_intersect_key([ + 'log' => 'report_log', + 'loglive' => 'report_loglive', + 'outline' => 'report_outline', + 'participation' => 'report_participation', + 'stats' => 'report_stats' + ], $allreports); + + $supportedreports = $logmanager->get_supported_reports('logstore_standard'); + foreach ($expectedreports as $expectedreport) { - $this->assertContains($expectedreport, $reports); + $this->assertArrayHasKey($expectedreport, $supportedreports); } }