From eb55f72d6323c0cb162f52f9866facd5e7709309 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Mon, 27 Jun 2016 11:32:11 +0800 Subject: [PATCH] MDL-55022 mod_lti: Fix undefined variable --- mod/lti/classes/external.php | 2 +- mod/lti/tests/externallib_test.php | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/mod/lti/classes/external.php b/mod/lti/classes/external.php index fca7c77906d..e6d5181daa3 100644 --- a/mod/lti/classes/external.php +++ b/mod/lti/classes/external.php @@ -523,7 +523,7 @@ class mod_lti_external extends external_api { } if (!empty($capabilityoffered)) { - $config->lti_capabilities = $capabilitiesoffered; + $config->lti_capabilities = $capabilityoffered; } if (!empty($serviceoffered)) { diff --git a/mod/lti/tests/externallib_test.php b/mod/lti/tests/externallib_test.php index b3ba4ea6901..a7f03237a0e 100644 --- a/mod/lti/tests/externallib_test.php +++ b/mod/lti/tests/externallib_test.php @@ -285,10 +285,12 @@ class mod_lti_external_testcase extends externallib_advanced_testcase { * Test create tool proxy */ public function test_mod_lti_create_tool_proxy() { - $proxy = mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), array(), array()); + $capabilities = ['AA', 'BB']; + $proxy = mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), $capabilities, []); $this->assertEquals('Test proxy', $proxy->name); $this->assertEquals($this->getExternalTestFileUrl('/test.html'), $proxy->regurl); $this->assertEquals(LTI_TOOL_PROXY_STATE_PENDING, $proxy->state); + $this->assertEquals(implode("\n", $capabilities), $proxy->capabilityoffered); } /*