diff --git a/mod/data/field/file/field.class.php b/mod/data/field/file/field.class.php index e29a7d69967..705c3db2b9b 100644 --- a/mod/data/field/file/field.class.php +++ b/mod/data/field/file/field.class.php @@ -38,7 +38,7 @@ class data_field_file extends data_field_base { // editing an existing database entry if ($formdata) { $fieldname = 'field_' . $this->field->id . '_file'; - $itemid = $formdata->$fieldname; + $itemid = clean_param($formdata->$fieldname, PARAM_INT); } else if ($recordid) { if ($content = $DB->get_record('data_content', array('fieldid'=>$this->field->id, 'recordid'=>$recordid))) { @@ -79,7 +79,7 @@ class data_field_file extends data_field_base { } // itemid element - $html .= ''; + $html .= ''; $options = new stdClass(); $options->maxbytes = $this->field->param3; @@ -104,7 +104,7 @@ class data_field_file extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function generate_sql($tablealias, $value) { diff --git a/mod/data/field/number/field.class.php b/mod/data/field/number/field.class.php index d04be455d48..4035f501c98 100644 --- a/mod/data/field/number/field.class.php +++ b/mod/data/field/number/field.class.php @@ -71,7 +71,7 @@ class data_field_number extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function parse_search_field() { diff --git a/mod/data/field/picture/field.class.php b/mod/data/field/picture/field.class.php index 36bcd55bc05..571fd739b97 100644 --- a/mod/data/field/picture/field.class.php +++ b/mod/data/field/picture/field.class.php @@ -39,7 +39,7 @@ class data_field_picture extends data_field_base { if ($formdata) { $fieldname = 'field_' . $this->field->id . '_file'; - $itemid = $formdata->$fieldname; + $itemid = clean_param($formdata->$fieldname, PARAM_INT); $fieldname = 'field_' . $this->field->id . '_alttext'; if (isset($formdata->$fieldname)) { $alttext = $formdata->$fieldname; @@ -109,7 +109,7 @@ class data_field_picture extends data_field_base { $str .= $output->render($fm); $str .= '
'; - $str .= ''; + $str .= ''; $str .= ' '; $str .= '
'; @@ -140,7 +140,7 @@ class data_field_picture extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function parse_search_field() { diff --git a/mod/data/field/text/field.class.php b/mod/data/field/text/field.class.php index 54cd497e4d9..90aee4c8d1d 100644 --- a/mod/data/field/text/field.class.php +++ b/mod/data/field/text/field.class.php @@ -27,7 +27,7 @@ class data_field_text extends data_field_base { var $type = 'text'; function display_search_field($value = '') { - return '' . ''; + return '' . ''; } function parse_search_field() { diff --git a/mod/data/field/textarea/field.class.php b/mod/data/field/textarea/field.class.php index a6e1b4cf925..5101a924fbd 100644 --- a/mod/data/field/textarea/field.class.php +++ b/mod/data/field/textarea/field.class.php @@ -79,7 +79,7 @@ class data_field_textarea extends data_field_base { } $fieldname = 'field_' . $this->field->id . '_itemid'; if (isset($formdata->$fieldname)) { - $draftitemid = $formdata->$fieldname; + $draftitemid = clean_param($formdata->$fieldname, PARAM_INT); } else { $draftitemid = file_get_unused_draft_itemid(); } @@ -146,7 +146,7 @@ class data_field_textarea extends data_field_base { } $editor->set_text($text); $editor->use_editor($field, $options, $fpoptions); - $str .= ''; + $str .= ''; $str .= '
'; $str .= '
'; $str .= '
'; @@ -166,7 +166,7 @@ class data_field_textarea extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function parse_search_field() { diff --git a/mod/data/field/url/field.class.php b/mod/data/field/url/field.class.php index 4d22f32a693..4557a1b542b 100644 --- a/mod/data/field/url/field.class.php +++ b/mod/data/field/url/field.class.php @@ -81,7 +81,7 @@ class data_field_url extends data_field_base { } $str .= ''; $str .= $label; - $str .= ''; + $str .= ''; $str .= ''; $str .= ''.get_string('text', 'data').':'; $str .= '' . get_string('fieldname', 'data') . '' . - ''; + ''; } function parse_search_field() { diff --git a/mod/data/lib.php b/mod/data/lib.php index 13fe7bfcbcf..c0e257c09d6 100644 --- a/mod/data/lib.php +++ b/mod/data/lib.php @@ -1730,9 +1730,9 @@ function data_print_preference_form($data, $perpage, $search, $sort='', $order=' $fn = !empty($search_array[DATA_FIRSTNAME]->data) ? $search_array[DATA_FIRSTNAME]->data : ''; $ln = !empty($search_array[DATA_LASTNAME]->data) ? $search_array[DATA_LASTNAME]->data : ''; $patterns[] = '/##firstname##/'; - $replacement[] = ''; + $replacement[] = ''; $patterns[] = '/##lastname##/'; - $replacement[] = ''; + $replacement[] = ''; // actual replacement of the tags $newtext = preg_replace($patterns, $replacement, $data->asearchtemplate);