diff --git a/mod/data/field/file/field.class.php b/mod/data/field/file/field.class.php index e29a7d69967..705c3db2b9b 100644 --- a/mod/data/field/file/field.class.php +++ b/mod/data/field/file/field.class.php @@ -38,7 +38,7 @@ class data_field_file extends data_field_base { // editing an existing database entry if ($formdata) { $fieldname = 'field_' . $this->field->id . '_file'; - $itemid = $formdata->$fieldname; + $itemid = clean_param($formdata->$fieldname, PARAM_INT); } else if ($recordid) { if ($content = $DB->get_record('data_content', array('fieldid'=>$this->field->id, 'recordid'=>$recordid))) { @@ -79,7 +79,7 @@ class data_field_file extends data_field_base { } // itemid element - $html .= ''; + $html .= ''; $options = new stdClass(); $options->maxbytes = $this->field->param3; @@ -104,7 +104,7 @@ class data_field_file extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function generate_sql($tablealias, $value) { diff --git a/mod/data/field/number/field.class.php b/mod/data/field/number/field.class.php index d04be455d48..4035f501c98 100644 --- a/mod/data/field/number/field.class.php +++ b/mod/data/field/number/field.class.php @@ -71,7 +71,7 @@ class data_field_number extends data_field_base { function display_search_field($value = '') { return '' . - ''; + ''; } function parse_search_field() { diff --git a/mod/data/field/picture/field.class.php b/mod/data/field/picture/field.class.php index 36bcd55bc05..571fd739b97 100644 --- a/mod/data/field/picture/field.class.php +++ b/mod/data/field/picture/field.class.php @@ -39,7 +39,7 @@ class data_field_picture extends data_field_base { if ($formdata) { $fieldname = 'field_' . $this->field->id . '_file'; - $itemid = $formdata->$fieldname; + $itemid = clean_param($formdata->$fieldname, PARAM_INT); $fieldname = 'field_' . $this->field->id . '_alttext'; if (isset($formdata->$fieldname)) { $alttext = $formdata->$fieldname; @@ -109,7 +109,7 @@ class data_field_picture extends data_field_base { $str .= $output->render($fm); $str .= '