From eaca013a20fa26ed4e5bdb40b69c0c046fb5e2d2 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Mon, 30 Sep 2019 13:13:06 +0100 Subject: [PATCH] MDL-66796 question bank: 0 is a valid question category idnumber --- question/category_class.php | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/question/category_class.php b/question/category_class.php index a3394624d00..7a9bdb8086f 100644 --- a/question/category_class.php +++ b/question/category_class.php @@ -436,9 +436,7 @@ class question_category_object { $cat->infoformat = $newinfoformat; $cat->sortorder = 999; $cat->stamp = make_unique_id_code(); - if ($idnumber) { - $cat->idnumber = $idnumber; - } + $cat->idnumber = $idnumber; $categoryid = $DB->insert_record("question_categories", $cat); // Log the creation of this category. @@ -511,9 +509,7 @@ class question_category_object { $cat->infoformat = $newinfoformat; $cat->parent = $parentid; $cat->contextid = $tocontextid; - if ($idnumber) { - $cat->idnumber = $idnumber; - } + $cat->idnumber = $idnumber; if ($newstamprequired) { $cat->stamp = make_unique_id_code(); }