From e968c5f9105d3eb44cf46e071eae3fbae506239b Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Tue, 20 Dec 2011 22:36:31 +0100 Subject: [PATCH] MDL-30761 make it work under Oracle. To revisit after MDL-29765 is done. --- lib/accesslib.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/accesslib.php b/lib/accesslib.php index 43fde862cac..b7c0c941970 100644 --- a/lib/accesslib.php +++ b/lib/accesslib.php @@ -1604,7 +1604,9 @@ function role_assign($roleid, $userid, $contextid, $component = '', $itemid = 0, $timemodified = time(); } -/// Check for existing entry + // Check for existing entry + // TODO: Revisit this sql_empty() use once Oracle bindings are improved. MDL-29765 + $component = ($component === '') ? $DB->sql_empty() : $component; $ras = $DB->get_records('role_assignments', array('roleid'=>$roleid, 'contextid'=>$context->id, 'userid'=>$userid, 'component'=>$component, 'itemid'=>$itemid), 'id'); if ($ras) { @@ -1717,6 +1719,10 @@ function role_unassign_all(array $params, $subcontexts = false, $includemanual = } } + // TODO: Revisit this sql_empty() use once Oracle bindings are improved. MDL-29765 + if (isset($params['component'])) { + $params['component'] = ($params['component'] === '') ? $DB->sql_empty() : $params['component']; + } $ras = $DB->get_records('role_assignments', $params); foreach($ras as $ra) { $DB->delete_records('role_assignments', array('id'=>$ra->id));