From 0e3ae707e09e7b4d178d679f1d9e9cc9c41039b9 Mon Sep 17 00:00:00 2001
From: Philipp Imhof <52650214+PhilippImhof@users.noreply.github.com>
Date: Fri, 23 May 2025 10:31:31 +0200
Subject: [PATCH] MDL-85565 phpunit: check for <select> before <option>

Make sure that assert_select_options() will fail when the output does
not contain a <select> and therefore does not have the given options.
---
 public/question/engine/tests/helpers.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/public/question/engine/tests/helpers.php b/public/question/engine/tests/helpers.php
index 46630f1b224..db5a7c6d6e5 100644
--- a/public/question/engine/tests/helpers.php
+++ b/public/question/engine/tests/helpers.php
@@ -574,6 +574,7 @@ abstract class question_testcase extends advanced_testcase {
         $dom = new DOMDocument();
         $dom->loadHTML($html);
         $selects = $dom->getElementsByTagName('select');
+        $this->assertGreaterThanOrEqual(1, $selects->count(), 'There is no <select> in the output.');
         foreach ($selects as $select) {
             if ($select->getAttribute('name') == $expectation->name) {
                 $options = $select->getElementsByTagName('option');