From e8897600a1a336c09abcbfd3398ada6e29b7fcc8 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Fri, 7 Jul 2023 18:27:07 +0200 Subject: [PATCH] MDL-78676 mod_data: Check completion rules properly The completion_rule_enabled() method was not checking all the fields and, in some cases, it was returning false (because it was not checking that "Count of entries" field was enabled). --- mod/data/mod_form.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/data/mod_form.php b/mod/data/mod_form.php index 5adcf9ce074..c75bb1bd3b3 100644 --- a/mod/data/mod_form.php +++ b/mod/data/mod_form.php @@ -145,7 +145,7 @@ class mod_data_mod_form extends moodleform_mod { * @return bool True if one or more rules is enabled, false if none are. */ public function completion_rule_enabled($data) { - return ($data['completionentries'] != 0); + return (!empty($data['completionentriesenabled']) && $data['completionentries'] != 0); } /**