From 394f65e91e093a793fb484a68bef20021bb0250d Mon Sep 17 00:00:00 2001 From: Joshua Ebarvia Date: Tue, 28 Sep 2021 12:29:01 +0930 Subject: [PATCH] MDL-67966 mod_workshop: Use condition to verify form is using editor This adds a condition to check if Online text is used for the submission. The functions file_postupdate_standard_editor and file_postupdate_standard_filemanager needs the property content_editor of the formdata. --- mod/workshop/exsubmission.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/mod/workshop/exsubmission.php b/mod/workshop/exsubmission.php index f8f3be05864..18c4e0f271c 100644 --- a/mod/workshop/exsubmission.php +++ b/mod/workshop/exsubmission.php @@ -156,10 +156,13 @@ if ($edit and $canmanage) { } // Save and relink embedded images and save attachments. - $formdata = file_postupdate_standard_editor($formdata, 'content', $workshop->submission_content_options(), - $workshop->context, 'mod_workshop', 'submission_content', $example->id); - $formdata = file_postupdate_standard_filemanager($formdata, 'attachment', $workshop->submission_attachment_options(), - $workshop->context, 'mod_workshop', 'submission_attachment', $example->id); + // To be used when Online text is allowed as a submission type. + if (!empty($formdata->content_editor)) { + $formdata = file_postupdate_standard_editor($formdata, 'content', $workshop->submission_content_options(), + $workshop->context, 'mod_workshop', 'submission_content', $example->id); + $formdata = file_postupdate_standard_filemanager($formdata, 'attachment', $workshop->submission_attachment_options(), + $workshop->context, 'mod_workshop', 'submission_attachment', $example->id); + } if (empty($formdata->attachment)) { // explicit cast to zero integer