From e719cbb6873c41d119e8ebd4f9e540c28ed0ecab Mon Sep 17 00:00:00 2001
From: Andrew Nicols <andrew@nicols.co.uk>
Date: Fri, 6 Jan 2023 12:57:52 +0800
Subject: [PATCH] MDL-76811 mod_data: strpos check should be strict

---
 mod/data/tests/generator_test.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mod/data/tests/generator_test.php b/mod/data/tests/generator_test.php
index ec105fb146f..4356e30606f 100644
--- a/mod/data/tests/generator_test.php
+++ b/mod/data/tests/generator_test.php
@@ -124,7 +124,9 @@ class generator_test extends \advanced_testcase {
 
         for ($i = 1; $i < $count; $i++) {
             $fieldname = 'field-' . $i;
-            $this->assertTrue(strpos($addtemplate, '[[' . $fieldname . ']]') >= 0);
+            $position = strpos($addtemplate, '[[' . $fieldname . ']]');
+            $this->assertIsNumeric($position);
+            $this->assertGreaterThanOrEqual(0, $position);
         }
     }