L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-77248 core: Move pre_enable_plugin_actions callback to enable_plugin

Browse Source 
Note: The original callback was incorrectly using the $PAGE output,
which cannot be relied upon in this callback. The best we can do here is
to add a notification to explain the situation.
This commit is contained in:
Andrew Nicols
2023-02-28 12:04:50 +08:00
parent 797b76becf
commit e6fe30187f
6 changed files with 102 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/modules.php
+7 -18
View File
@@ -48,31 +48,20 @@ $strshowmodulecourse = get_string('showmodulecourse');
// If data submitted, then process and store.
if (!empty($hide) && confirm_sesskey()) {
$class = \core_plugin_manager::resolve_plugininfo_class('mod');
$class::enable_plugin($hide, false);
// Settings not required - only pages.
admin_get_root(true, false);
if ($class::enable_plugin($hide, false)) {
// Settings not required - only pages.
admin_get_root(true, false);
}
redirect(new moodle_url('/admin/modules.php'));
}
if (!empty($show) && confirm_sesskey()) {
$canenablemodule = true;
$modulename = $show;
// Invoking a callback function that enables plugins to force additional actions (e.g. displaying notifications,
// modals, etc.) and also specify through its returned value (bool) whether the process of enabling the plugin
// should continue after these actions or not.
if (component_callback_exists("mod_{$modulename}", 'pre_enable_plugin_actions')) {
$canenablemodule = component_callback("mod_{$modulename}", 'pre_enable_plugin_actions');
}
if ($canenablemodule) {
$class = \core_plugin_manager::resolve_plugininfo_class('mod');
$class::enable_plugin($show, true);
$class = \core_plugin_manager::resolve_plugininfo_class('mod');
if ($class::enable_plugin($show, true)) {
// Settings not required - only pages.
admin_get_root(true, false);
redirect(new moodle_url('/admin/modules.php'));
}
redirect(new moodle_url('/admin/modules.php'));
}
echo $OUTPUT->header();